You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was wondering if I make a significant change to a function in the dev branch would you prefer if I create a modified copy of the original or just overwrite the previous function. For example, I had a look in into the band functions and had some ideas on some of the internals (temporal filters and band_func). I could create copies, for example, (yearly_filter2, band_func2, and then band2) or just edit them in place. Since I am still familiarizing myself with the code, I could see potential benefits to either, but might lean towards editing them in place. Also when making a PR should I do it to jle-workspace ?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
Hi @joshualerickson ,
I was wondering if I make a significant change to a function in the dev branch would you prefer if I create a modified copy of the original or just overwrite the previous function. For example, I had a look in into the
band
functions and had some ideas on some of the internals (temporal filters
andband_func
). I could create copies, for example, (yearly_filter2
,band_func2
, and thenband2
) or just edit them in place. Since I am still familiarizing myself with the code, I could see potential benefits to either, but might lean towards editing them in place. Also when making a PR should I do it tojle-workspace
?Beta Was this translation helpful? Give feedback.
All reactions