Rename test fixtures for consistency between sync and async

Author: joshuadavidthomas

tests/conftest.py

@@ -127,8 +127,8 @@ def repository_id():
 
 
 @pytest.fixture
-def get_mock_github_api():
-    def _get_mock_github_api(return_data, installation_id=12345):
+def aget_mock_github_api():
+    def _aget_mock_github_api(return_data, installation_id=12345):
         mock_api = AsyncMock(spec=AsyncGitHubAPI)
 
         async def mock_getitem(*args, **kwargs):
@@ -146,12 +146,12 @@ async def mock_getiter(*args, **kwargs):
 
         return mock_api
 
-    return _get_mock_github_api
+    return _aget_mock_github_api
 
 
 @pytest.fixture
-def get_mock_github_api_sync():
-    def _get_mock_github_api_sync(return_data, installation_id=12345):
+def get_mock_github_api():
+    def _get_mock_github_api(return_data, installation_id=12345):
         from django_github_app.github import SyncGitHubAPI
 
         mock_api = MagicMock(spec=SyncGitHubAPI)
@@ -172,15 +172,15 @@ def mock_post(*args, **kwargs):
 
         return mock_api
 
-    return _get_mock_github_api_sync
+    return _get_mock_github_api
 
 
 @pytest.fixture
-def installation(get_mock_github_api, baker):
+def installation(aget_mock_github_api, baker):
     installation = baker.make(
         "django_github_app.Installation", installation_id=seq.next()
     )
-    mock_github_api = get_mock_github_api(
+    mock_github_api = aget_mock_github_api(
         [
             {"id": seq.next(), "node_id": "node1", "full_name": "owner/repo1"},
             {"id": seq.next(), "node_id": "node2", "full_name": "owner/repo2"},
@@ -192,11 +192,11 @@ def installation(get_mock_github_api, baker):
 
 
 @pytest_asyncio.fixture
-async def ainstallation(get_mock_github_api, baker):
+async def ainstallation(aget_mock_github_api, baker):
     installation = await sync_to_async(baker.make)(
         "django_github_app.Installation", installation_id=seq.next()
     )
-    mock_github_api = get_mock_github_api(
+    mock_github_api = aget_mock_github_api(
         [
             {"id": seq.next(), "node_id": "node1", "full_name": "owner/repo1"},
             {"id": seq.next(), "node_id": "node2", "full_name": "owner/repo2"},
@@ -208,14 +208,14 @@ async def ainstallation(get_mock_github_api, baker):
 
 
 @pytest.fixture
-def repository(installation, get_mock_github_api, baker):
+def repository(installation, aget_mock_github_api, baker):
     repository = baker.make(
         "django_github_app.Repository",
         repository_id=seq.next(),
         full_name="owner/repo",
         installation=installation,
     )
-    mock_github_api = get_mock_github_api(
+    mock_github_api = aget_mock_github_api(
         [
             {
                 "number": 1,
@@ -235,14 +235,14 @@ def repository(installation, get_mock_github_api, baker):
 
 
 @pytest_asyncio.fixture
-async def arepository(ainstallation, get_mock_github_api, baker):
+async def arepository(ainstallation, aget_mock_github_api, baker):
     repository = await sync_to_async(baker.make)(
         "django_github_app.Repository",
         repository_id=seq.next(),
         full_name="owner/repo",
         installation=ainstallation,
     )
-    mock_github_api = get_mock_github_api(
+    mock_github_api = aget_mock_github_api(
         [
             {
                 "number": 1,