Doesn't work with edge verision

[kennyadsl]

Hi, I'm trying to get this extension working with the edge version. Migrations are ok but when I try to run the server I get the following error:

ActionView::Template::Error (undefined method `upcase' for nil:NilClass):
    29:   <div id="admin-menu" data-hook>
    30:     <ul data-hook="admin_tabs">
    31: <%= render 'admin/shared/tabs' %>
    32:     <%= tab(:pages) %><%= tab(:promotions) %><%=  tab(:question_categories, :label => :question_categories_admin) %>
    33: </ul>
    34: <br class="clear">
    35: </div>

I think it's related to this deprecation warning:

[DEPRECATION] `insert_bottom` hook method is deprecated, replace hook call with: 
Deface::Override.new(:virtual_path => "layouts/admin",
                     :name => "converted_admin_tabs_652663900",
                     :insert_bottom => "[data-hook='admin_tabs'], #admin_tabs[data-hook]",
                     :text => "<%=  tab(:question_categories, :label => :question_categories_admin) %>",
                     :disabled => false)

[joshnuss]

I am in the process of upgrading it to the latest spree version. it should
be working shortly

-josh

On Wed, Sep 28, 2011 at 11:59 AM, Alberto Vena <
reply@reply.github.com>wrote:

Hi, I'm trying to get this extension working with the edge version.
Migrations are ok but when I try to run the server I get the following
error:

ActionView::Template::Error (undefined method `upcase' for nil:NilClass):
   29:   <div id="admin-menu" data-hook>
   30:     <ul data-hook="admin_tabs">
   31: <%= render 'admin/shared/tabs' %>
   32:     <%= tab(:pages) %><%= tab(:promotions) %><%=
 tab(:question_categories, :label => :question_categories_admin) %>
   33: </ul>
   34: <br class="clear">
   35: </div>

I think it's related to this deprecation warning:

[DEPRECATION] `insert_bottom` hook method is deprecated, replace hook call
with:
Deface::Override.new(:virtual_path => "layouts/admin",
                    :name => "converted_admin_tabs_652663900",
                    :insert_bottom => "[data-hook='admin_tabs'],
#admin_tabs[data-hook]",
                    :text => "<%=  tab(:question_categories, :label =>
:question_categories_admin) %>",
                    :disabled => false)

Reply to this email directly or view it on GitHub:
#5

[kennyadsl]

I'm doing a 0.70.x branch on my fork trying to emulate
spree_static_content and other updated extension behavior. If it works
for me I can make a pull request on your repo. Ok?

2011/9/28 Joshua Nussbaum
reply@reply.github.com:

I am in the process of upgrading it to the latest spree version. it should
be working shortly

-josh

On Wed, Sep 28, 2011 at 11:59 AM, Alberto Vena <
reply@reply.github.com>wrote:

Hi, I'm trying to get this extension working with the edge version.
Migrations are ok but when I try to run the server I get the following
error:

ActionView::Template::Error (undefined method `upcase' for nil:NilClass):
   29:   <div id="admin-menu" data-hook>
   30:     <ul data-hook="admin_tabs">
   31: <%= render 'admin/shared/tabs' %>
   32:     <%= tab(:pages) %><%= tab(:promotions) %><%=
 tab(:question_categories, :label => :question_categories_admin) %>
   33: </ul>
   34: <br class="clear">
   35: </div>

I think it's related to this deprecation warning:

[DEPRECATION] `insert_bottom` hook method is deprecated, replace hook call
with:
Deface::Override.new(:virtual_path => "layouts/admin",
                    :name => "converted_admin_tabs_652663900",
                    :insert_bottom => "[data-hook='admin_tabs'],
#admin_tabs[data-hook]",
                    :text => "<%=  tab(:question_categories, :label =>
:question_categories_admin) %>",
                    :disabled => false)

Reply to this email directly or view it on GitHub:
#5

Reply to this email directly or view it on GitHub:
#5 (comment)

---

Alberto Vena | Chieti | +39 338 6638679

[joshnuss]

thanks!

though i did test it last week and it worked, though still need to figure
out why the tests wont run

On Wed, Sep 28, 2011 at 12:10 PM, Alberto Vena <
reply@reply.github.com>wrote:

I'm doing a 0.70.x branch on my fork trying to emulate
spree_static_content and other updated extension behavior. If it works
for me I can make a pull request on your repo. Ok?

2011/9/28 Joshua Nussbaum
reply@reply.github.com:

I am in the process of upgrading it to the latest spree version. it
should
be working shortly

-josh

On Wed, Sep 28, 2011 at 11:59 AM, Alberto Vena <
reply@reply.github.com>wrote:

Hi, I'm trying to get this extension working with the edge version.
Migrations are ok but when I try to run the server I get the following
error:

ActionView::Template::Error (undefined method `upcase' for
nil:NilClass):
   29:   <div id="admin-menu" data-hook>
   30:     <ul data-hook="admin_tabs">
   31: <%= render 'admin/shared/tabs' %>
   32:     <%= tab(:pages) %><%= tab(:promotions) %><%=
 tab(:question_categories, :label => :question_categories_admin) %>
   33: </ul>
   34: <br class="clear">
   35: </div>

I think it's related to this deprecation warning:

[DEPRECATION] `insert_bottom` hook method is deprecated, replace hook
call
with:
Deface::Override.new(:virtual_path => "layouts/admin",
                    :name => "converted_admin_tabs_652663900",
                    :insert_bottom => "[data-hook='admin_tabs'],
#admin_tabs[data-hook]",
                    :text => "<%=  tab(:question_categories, :label =>
:question_categories_admin) %>",
                    :disabled => false)

Reply to this email directly or view it on GitHub:
#5

Reply to this email directly or view it on GitHub:
#5 (comment)

---

Alberto Vena | Chieti | +39 338 6638679

Reply to this email directly or view it on GitHub:
#5 (comment)

[kennyadsl]

Hi, I made the new 0.70.x branch (in my fork located here: nebulab/spree-faq). It seems to work form me with edge but I would like to test well the extension before make the pull request. How do you usually run tests for this app?

[joshnuss]

i believe there is an issue running tests on the current spree edge version.

usually it would be

rake test_app
rake spec

but its getting errors... tried creating a brand new extension with spree
"spree extension foo; cd foo; rake test_app spec", but that also gives
errors, so i need to do some digging

On Thu, Sep 29, 2011 at 4:39 AM, Alberto Vena <
reply@reply.github.com>wrote:

Hi, I made the new 0.70.x branch (in my fork located here:
nebulab/spree-faq). It seems to work form me with edge but I would like to
test well the extension before make the pull request. How do you usually run
tests for this app?

Reply to this email directly or view it on GitHub:
#5 (comment)

[kennyadsl]

Ok, I figure out why test don't work for me too. Thanks.