Skip to content

Commit 62706f6

Browse files
committed
fix HeatMap constructor for iterator
1 parent 25ba8dc commit 62706f6

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name = "OnlineStats"
22
uuid = "a15396b6-48d5-5d58-9928-6d29437db91e"
3-
version = "1.5.11"
3+
version = "1.5.12"
44

55
[deps]
66
AbstractTrees = "1520ce14-60c1-5f80-bbc7-55ef81b5835c"

src/viz/heatmap.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ end
3737
_heatmap_range(x, bins) = range(extrema(x)..., length=bins)
3838

3939
function HeatMap(itr, bins::Integer=200; kw...)
40-
xrng = _heatmap_range(first.(itr))
41-
yrng = _heatmap_range(last.(itr))
40+
xrng = _heatmap_range(first.(itr), bins)
41+
yrng = _heatmap_range(last.(itr), bins)
4242
fit!(HeatMap(xrng, yrng; kw...), itr)
4343
end
4444
nobs(o::HeatMap) = sum(o.counts) + o.out
@@ -107,4 +107,4 @@ end
107107
o.yedges, vec(sum(o.counts, dims=1))
108108
end
109109
end
110-
end
110+
end

test/runtests.jl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -178,6 +178,7 @@ end
178178
data1 = zip(ymat[:,1], ymat[:,2])
179179
data2 = zip(ymat2[:,1], ymat2[:,2])
180180
@test ==(mergevals(HeatMap(-5:.1:5, -5:.1:5), data1, data2)...)
181+
@test nobs(HeatMap(data1)) == length(data1)
181182
end
182183
#-----------------------------------------------------------------------# Hist
183184
@testset "Hist" begin

0 commit comments

Comments
 (0)