Merge pull request authzed#1717 from josephschorr/telemetry-warn

Change telemetry failure to a warning and have Postgres check for its unique ID on startup

Author: vroldanbet

internal/datastore/postgres/postgres.go

@@ -547,12 +547,19 @@ func (pgd *pgDatastore) ReadyState(ctx context.Context) (datastore.ReadyState, e
 	}
 
 	if version == headMigration {
+		// Ensure a datastore ID is present. This ensures the tables have not been truncated.
+		uniqueID, err := pgd.datastoreUniqueID(ctx)
+		if err != nil {
+			return datastore.ReadyState{}, fmt.Errorf("database validation failed: %w; if you have previously run `TRUNCATE`, this database is no longer valid and must be remigrated. See: https://spicedb.dev/d/truncate-unsupported", err)
+		}
+
+		log.Trace().Str("unique_id", uniqueID).Msg("postgres datastore unique ID")
 		return datastore.ReadyState{IsReady: true}, nil
 	}
 
 	return datastore.ReadyState{
 		Message: fmt.Sprintf(
-			"datastore is not migrated: currently at revision `%s`, but requires `%s`. Please run `spicedb migrate`.",
+			"datastore is not migrated: currently at revision `%s`, but requires `%s`. Please run `spicedb migrate`. If you have previously run `TRUNCATE`, this database is no longer valid and must be remigrated. See: https://spicedb.dev/d/truncate-unsupported",
 			version,
 			headMigration,
 		),

internal/datastore/postgres/stats.go

@@ -28,6 +28,18 @@ var (
 				Where(sq.Eq{colRelname: tableTuple})
 )
 
+func (pgd *pgDatastore) datastoreUniqueID(ctx context.Context) (string, error) {
+	idSQL, idArgs, err := queryUniqueID.ToSql()
+	if err != nil {
+		return "", fmt.Errorf("unable to generate query sql: %w", err)
+	}
+
+	var uniqueID string
+	return uniqueID, pgx.BeginTxFunc(ctx, pgd.readPool, pgd.readTxOptions, func(tx pgx.Tx) error {
+		return tx.QueryRow(ctx, idSQL, idArgs...).Scan(&uniqueID)
+	})
+}
+
 func (pgd *pgDatastore) Statistics(ctx context.Context) (datastore.Stats, error) {
 	idSQL, idArgs, err := queryUniqueID.ToSql()
 	if err != nil {

pkg/cmd/server/server.go

@@ -439,15 +439,17 @@ func (c *Config) Complete(ctx context.Context) (RunnableServer, error) {
 		log.Ctx(ctx).Debug().Msg("initializing telemetry collector")
 		registry, err := telemetry.RegisterTelemetryCollector(c.DatastoreConfig.Engine, ds)
 		if err != nil {
-			return nil, fmt.Errorf("unable to initialize telemetry collector: %w", err)
-		}
-
-		telemetryRegistry = registry
-		reporter, err = telemetry.RemoteReporter(
-			telemetryRegistry, c.TelemetryEndpoint, c.TelemetryCAOverridePath, c.TelemetryInterval,
-		)
-		if err != nil {
-			return nil, fmt.Errorf("unable to initialize metrics reporter: %w", err)
+			log.Warn().Err(err).Msg("unable to initialize telemetry collector")
+		} else {
+			telemetryRegistry = registry
+			reporter, err = telemetry.RemoteReporter(
+				telemetryRegistry, c.TelemetryEndpoint, c.TelemetryCAOverridePath, c.TelemetryInterval,
+			)
+			if err != nil {
+				log.Warn().Err(err).Msg("unable to initialize telemetry reporter")
+				telemetryRegistry = nil
+				reporter = telemetry.DisabledReporter
+			}
 		}
 	}