Skip to content

Commit 87b7ed4

Browse files
committed
better documentation
1 parent 2aaf497 commit 87b7ed4

File tree

4 files changed

+9
-4
lines changed

4 files changed

+9
-4
lines changed

NormalMapGeneratorTool/NormalMapGeneratorTool.vcxproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
<ConfigurationType>Application</ConfigurationType>
3636
<UseDebugLibraries>false</UseDebugLibraries>
3737
<PlatformToolset>v141</PlatformToolset>
38-
<WholeProgramOptimization>true</WholeProgramOptimization>
38+
<WholeProgramOptimization>false</WholeProgramOptimization>
3939
<CharacterSet>MultiByte</CharacterSet>
4040
</PropertyGroup>
4141
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'" Label="Configuration">
@@ -109,7 +109,7 @@
109109
<Optimization>MaxSpeed</Optimization>
110110
<FunctionLevelLinking>true</FunctionLevelLinking>
111111
<IntrinsicFunctions>true</IntrinsicFunctions>
112-
<SDLCheck>true</SDLCheck>
112+
<SDLCheck>false</SDLCheck>
113113
<ConformanceMode>true</ConformanceMode>
114114
<AdditionalIncludeDirectories>$(SolutionDir)\includes;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
115115
<InlineFunctionExpansion>AnySuitable</InlineFunctionExpansion>
@@ -122,7 +122,7 @@
122122
<OptimizeReferences>true</OptimizeReferences>
123123
<AdditionalDependencies>glew32.lib;glew32s.lib;glfw3.lib;Opengl32.lib;assimp.lib;%(AdditionalDependencies)</AdditionalDependencies>
124124
<AdditionalLibraryDirectories>$(SolutionDir)\lib;%(AdditionalLibraryDirectories)</AdditionalLibraryDirectories>
125-
<SubSystem>NotSet</SubSystem>
125+
<SubSystem>Windows</SubSystem>
126126
<EntryPointSymbol>mainCRTStartup</EntryPointSymbol>
127127
</Link>
128128
</ItemDefinitionGroup>

NormalMapGeneratorTool/Resources/Shaders/modelView.fs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,6 @@ void main()
283283
vec3 diffuseAndAmbient = diffuse + ambient;
284284
vec3 reflectionCol = textureLod(skybox, reflect(-viewDir, norm), _Roughness).rgb;
285285
vec3 result = mix(diffuseAndAmbient, reflectionCol, _Reflectivity) + specular;
286-
//result = result/(result + vec3(1.0));
287286
result = pow(result, vec3(1.0/2.2));
288287
FragColor = vec4(result, 1.0);//PBR_Colour(norm, _CameraPosition, FragPos, vec3(1,1,1), 1.0, 0.4, lightPos);
289288
}

NormalMapGeneratorTool/src/MainApp.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -428,11 +428,13 @@ int main(void)
428428
glClearColor(0.1f, 0.1f, 0.1f, 1.0);
429429
glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT);
430430

431+
// Draw the frame by using the frame buffer texture
431432
frameShader.use();
432433
frameShader.applyShaderUniformMatrix(frameModelMatrixUniform, frameDrawingPanel.getTransform()->getMatrix());
433434
frameDrawingPanel.setTextureID(fbs.getColourTexture());
434435
frameDrawingPanel.draw();
435436

437+
// Set up the preview frame buffer and then render the 3d model
436438
previewFbs.BindFrameBuffer();
437439

438440
glEnable(GL_DEPTH_TEST);
@@ -459,6 +461,7 @@ int main(void)
459461
}
460462
prevMcord = windowSys.GetCursorPos();
461463

464+
// Set up preview model uniforms
462465
modelViewShader.use();
463466
modelViewShader.applyShaderUniformMatrix(modelPreviewModelUniform, glm::mat4());
464467
modelViewShader.applyShaderUniformMatrix(modelPreviewViewUniform, glm::lookAt(cameraPosition, glm::vec3(0), glm::vec3(0, 1, 0)));
@@ -504,12 +507,14 @@ int main(void)
504507
modelPreviewObj->draw();
505508
glActiveTexture(GL_TEXTURE0);
506509

510+
// Set up preview shader uniforms
507511
gridLineShader.use();
508512
gridLineShader.applyShaderUniformMatrix(gridLineModelMatrixUniform, glm::scale(glm::mat4(), glm::vec3(100, 0, 100)));
509513
gridLineShader.applyShaderUniformMatrix(gridLineViewMatrixUniform, glm::lookAt(cameraPosition, glm::vec3(0), glm::vec3(0, 1, 0)));
510514
gridLineShader.applyShaderUniformMatrix(gridLineProjectionMatrixUniform, glm::perspective(glm::radians(45.0f), 1.0f, 0.1f, 100.0f));
511515
previewPlane->draw();
512516

517+
// Set up the default framebuffer
513518
glBindFramebuffer(GL_FRAMEBUFFER, 0);
514519

515520
if (windowSys.GetWindowRes().x < windowSys.GetWindowRes().y)

NormalMapGeneratorTool/src/WindowSystem.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ void WindowSystem::Init(const std::string windowTitle, int windowWidth, int wind
1717
/*glfwWindowHint(GLFW_CONTEXT_VERSION_MAJOR, 3);
1818
glfwWindowHint(GLFW_CONTEXT_VERSION_MINOR, 3);
1919
glfwWindowHint(GLFW_OPENGL_PROFILE, GLFW_OPENGL_CORE_PROFILE);*/
20+
2021
window = glfwCreateWindow(windowRes.x, windowRes.y, windowTitle.c_str(), NULL, NULL);
2122
videoMode = glfwGetVideoMode(glfwGetPrimaryMonitor());
2223
maxWindowRes.x = videoMode->width;

0 commit comments

Comments
 (0)