Skip to content

Commit 12def6d

Browse files
cortinicofacebook-github-bot
authored andcommitted
Update the reproducer message (facebook#50848)
Summary: Pull Request resolved: facebook#50848 This clarifies our reproducer guidelines. It's also currently pending on this other PR on the website: facebook/react-native-website#4589 Changelog: [Internal] [Changed] - Reviewed By: cipolleschi Differential Revision: D73194317 fbshipit-source-id: 35a0e6b4def734c8cff5099ab426d024f9ff6c4d
1 parent 4221fc8 commit 12def6d

File tree

4 files changed

+15
-10
lines changed

4 files changed

+15
-10
lines changed

.github/ISSUE_TEMPLATE/bug_report.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@ body:
1919
* Please [search for similar issues](https://github.com/facebook/react-native/issues) in our issue tracker.
2020
2121
Make sure that your issue:
22-
* Have a **valid reproducer** (either a [Expo Snack](https://snack.expo.dev/) or a [empty project from template](https://github.com/react-native-community/reproducer-react-native).
22+
* Have a **valid reproducer** (See [How to report a bug](https://reactnative.dev/contributing/how-to-report-a-bug)).
2323
* Is tested against the [**latest stable**](https://github.com/facebook/react-native/releases/) of React Native.
2424
25-
Due to the extreme number of bugs we receive, we will be looking **ONLY** into issues with a reproducer, and on [supported versions](https://github.com/reactwg/react-native-releases#which-versions-are-currently-supported) of React Native.
25+
🚨 IMPORTANT: Due to the extreme number of bugs we receive, issues **without a reproducer** or for an [**unsupported versions**](https://github.com/reactwg/react-native-releases#which-versions-are-currently-supported) of React Native **will be closed**.
2626
- type: textarea
2727
id: description
2828
attributes:
@@ -109,8 +109,8 @@ body:
109109
- type: input
110110
id: reproducer
111111
attributes:
112-
label: Reproducer
113-
description: A link to a Expo Snack or a public repository that reproduces this bug, using [this template](https://github.com/react-native-community/reproducer-react-native). Reproducers are **mandatory**.
112+
label: MANDATORY Reproducer
113+
description: A link to either a failing RNTesterPlayground.js file, an Expo Snack or a public repository from [this template](https://github.com/react-native-community/reproducer-react-native) that reproduces this bug. Reproducers are **mandatory**, issues without a reproducer will be closed.
114114
placeholder: "https://github.com/<myuser>/<myreproducer>"
115115
validations:
116116
required: true

.github/ISSUE_TEMPLATE/new_architecture_bug_report.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@ body:
1616
Do not attempt to open a bug in this category if you're not using the New Architecture as your bug will be closed.
1717
1818
Make sure that your issue:
19-
* Have a **valid reproducer** (either a [Expo Snack](https://snack.expo.dev/) or a [empty project from template](https://github.com/react-native-community/reproducer-react-native).
19+
* Have a **valid reproducer** (See [How to report a bug](https://reactnative.dev/contributing/how-to-report-a-bug)).
2020
* Is tested against the [**latest stable**](https://github.com/facebook/react-native/releases/) of React Native.
2121
22-
Due to the extreme number of bugs we receive, we will be looking **ONLY** into issues with a reproducer, and on [supported versions](https://github.com/reactwg/react-native-releases#which-versions-are-currently-supported) of React Native.
22+
🚨 IMPORTANT: Due to the extreme number of bugs we receive, issues **without a reproducer** or for an [**unsupported versions**](https://github.com/reactwg/react-native-releases#which-versions-are-currently-supported) of React Native **will be closed**.
2323
- type: textarea
2424
id: description
2525
attributes:
@@ -121,8 +121,8 @@ body:
121121
- type: input
122122
id: reproducer
123123
attributes:
124-
label: Reproducer
125-
description: A link to a Expo Snack or a public repository that reproduces this bug, using [this template](https://github.com/react-native-community/reproducer-react-native). Reproducers are **mandatory**.
124+
label: MANDATORY Reproducer
125+
description: A link to either a failing RNTesterPlayground.js file, an Expo Snack or a public repository from [this template](https://github.com/react-native-community/reproducer-react-native) that reproduces this bug. Reproducers are **mandatory**, issues without a reproducer will be closed.
126126
placeholder: "https://github.com/<myuser>/<myreproducer>"
127127
validations:
128128
required: true

.github/workflow-scripts/actOnLabel.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ module.exports = async (github, context, labelWithContext) => {
111111
case 'Needs: Repro':
112112
await addComment(
113113
`> [!WARNING]\n` +
114-
`> **Missing reproducer**: We could not detect a reproducible example in your issue report. Please provide either: <br/><ul><li>If your bug is UI related: a [Snack](https://snack.expo.dev)</li><li> If your bug is build/upgrade related: a project using our [Reproducer Template](https://github.com/react-native-community/reproducer-react-native/generate)</li><li>Otherwise send us a Pull Request with the [RNTesterPlayground.js](https://github.com/facebook/react-native/blob/main/packages/rn-tester/js/examples/Playground/RNTesterPlayground.js) edited to reproduce your bug.</li></ul>`,
114+
`> **Missing reproducer**: We could not detect a reproducible example in your issue report. Reproducers are **mandatory** and we can accept only one of those as a valid reproducer: <br/><ul><li>For majority of bugs: send us a Pull Request with the [RNTesterPlayground.js](https://github.com/facebook/react-native/blob/main/packages/rn-tester/js/examples/Playground/RNTesterPlayground.js) edited to reproduce your bug.</li><li>If your bug is UI related: a [Snack](https://snack.expo.dev)</li><li> If your bug is build/upgrade related: a project using our [Reproducer Template](https://github.com/react-native-community/reproducer-react-native/generate)</li></ul><br/>You can read more about about it on our website: [How to report a bug](https://reactnative.dev/contributing/how-to-report-a-bug).`,
115115
);
116116
await requestAuthorFeedback();
117117
return;

.github/workflow-scripts/checkForReproducer.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,11 @@ module.exports = async (github, context) => {
4141

4242
// Look for Snack or a GH repo associated with the user that added an issue or comment
4343
const hasValidReproducer = entities.some(entity => {
44+
const hasPullRequestRepoLink = containsPattern(
45+
entity.body,
46+
`https?:\/\/github\.com\/facebook\/react-native\/pull\/\d+\/?`,
47+
);
48+
4449
const hasExpoSnackLink = containsPattern(
4550
entity.body,
4651
`https?:\\/\\/snack\\.expo\\.dev\\/[^\\s)\\]]+`,
@@ -50,7 +55,7 @@ module.exports = async (github, context) => {
5055
entity.body,
5156
`https?:\\/\\/github\\.com\\/(${entity.user.login})\\/[^/]+\\/?\\s?`,
5257
);
53-
return hasExpoSnackLink || hasGithubRepoLink;
58+
return hasPullRequestRepoLink || hasExpoSnackLink || hasGithubRepoLink;
5459
});
5560

5661
if (hasValidReproducer) {

0 commit comments

Comments
 (0)