Skip to content

Commit 9212871

Browse files
authored
Merge pull request #15 from jonsagara/fix/gmt
Fixes #14: Make PostDateGmt and PostModifiedGmt nullable because they can contain empty values
2 parents 30b36d5 + 7e33691 commit 9212871

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

Directory.Build.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
<Nullable>enable</Nullable>
99

1010
<!-- NuGet -->
11-
<Version>1.1.0</Version>
11+
<Version>1.1.1</Version>
1212
<AssemblyVersion>1.0.0.0</AssemblyVersion>
1313
<FileVersion>1.0.0.0</FileVersion>
1414
<Authors>Armin Reiter; Jon Sagara</Authors>

src/Sagara.FeedReader/Modules/WordPressExport/WordPressExportItem.cs

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public class WordPressExportItem
3131
/// <summary>
3232
/// The post_date_gmt element's value.
3333
/// </summary>
34-
public DateTime PostDateGmt { get; set; }
34+
public DateTime? PostDateGmt { get; set; }
3535

3636
/// <summary>
3737
/// The post_modified element's value.
@@ -41,7 +41,7 @@ public class WordPressExportItem
4141
/// <summary>
4242
/// The post_modified_gmt element's value.
4343
/// </summary>
44-
public DateTime PostModifiedGmt { get; set; }
44+
public DateTime? PostModifiedGmt { get; set; }
4545

4646
/// <summary>
4747
/// The comment_status element's value.
@@ -109,9 +109,14 @@ public WordPressExportItem(XElement itemElement)
109109

110110
PostId = Helpers.TryParseLong(itemElement.GetChildElementValue(namespacePrefix: WordPressExportChannel.NamespacePrefix, elementName: "post_id"))!.Value;
111111
PostDate = Helpers.TryParseDateTime(itemElement.GetChildElementValue(namespacePrefix: WordPressExportChannel.NamespacePrefix, elementName: "post_date"))!.Value;
112-
PostDateGmt = itemElement.GetChildElementValue(namespacePrefix: WordPressExportChannel.NamespacePrefix, elementName: "post_date_gmt").ParseUtcOrDefault()!.Value;
112+
113+
// We can't assume that a post will have a valid GMT date. One of my entries did not.
114+
PostDateGmt = itemElement.GetChildElementValue(namespacePrefix: WordPressExportChannel.NamespacePrefix, elementName: "post_date_gmt").ParseUtcOrDefault();
115+
113116
PostModified = Helpers.TryParseDateTime(itemElement.GetChildElementValue(namespacePrefix: WordPressExportChannel.NamespacePrefix, elementName: "post_modified"))!.Value;
114-
PostModifiedGmt = itemElement.GetChildElementValue(namespacePrefix: WordPressExportChannel.NamespacePrefix, elementName: "post_modified_gmt").ParseUtcOrDefault()!.Value;
117+
118+
// We can't assume that a post will have a valid GMT date. One of my entries did not.
119+
PostModifiedGmt = itemElement.GetChildElementValue(namespacePrefix: WordPressExportChannel.NamespacePrefix, elementName: "post_modified_gmt").ParseUtcOrDefault();
115120

116121
CommentStatus = itemElement.GetChildElementValue(namespacePrefix: WordPressExportChannel.NamespacePrefix, elementName: "comment_status")!;
117122
PingStatus = itemElement.GetChildElementValue(namespacePrefix: WordPressExportChannel.NamespacePrefix, elementName: "ping_status")!;

0 commit comments

Comments
 (0)