Inconsistent Code

[rmccu]

NebulaLogger/nebula-logger/core/main/log-management/classes/LogEntryEventHandler.cls

Line 162 in 3b04138

LogEntry__c logEntry = new LogEntry__c(

Why does it use this format (setting the attributes inside of the LogEntry__c() constructor in the insertLogEntries() method, but in the upsertLogs() it creates a new instance of Log__c and then sets each attribute. Seems inconsistent. If there is a reason for this, there should be a comment explaining it.

[jongpie]

@rmccu the commit you're referencing, 3b04138, is 4-5 months old (v4.7.1). In the latest version, v4.8.3, the constructors are now used for both Log__c and LogEntry__c to set most fields.

[rmccu]

Not sure how I found the old version. I think I just searched and it took me to the old version. I didn't think to look at a newer version or "main".