fix pana score

Author: jonataslaw

CHANGELOG.md

@@ -1,3 +1,11 @@
+## [5.0.0-release-candidate-9.3.2]
+
+- Fix pana score
+
+## [5.0.0-release-candidate-9.3.1]
+
+- Fix lint errors
+
 ## [5.0.0-release-candidate-9.3.0]
 
 - Support for Flutter 3.29.0

example_nav2/lib/main.dart

@@ -1,7 +1,7 @@
-import 'package:example_nav2/services/auth_service.dart';
 import 'package:flutter/material.dart';
 import 'package:get/get.dart';
 
+import './services/auth_service.dart';
 import 'app/routes/app_pages.dart';
 
 void main() {

lib/get_navigation/src/routes/get_navigator.dart

@@ -1,57 +1,17 @@
 import 'package:flutter/widgets.dart';
 
-import '../../../get.dart';
-
 class GetNavigator extends Navigator {
-  GetNavigator.onGenerateRoute({
-    GlobalKey<NavigatorState>? super.key,
-    bool Function(Route<dynamic>, dynamic)? onPopPage,
-    required List<GetPage> super.pages,
-    List<NavigatorObserver>? observers,
-    super.reportsRouteUpdateToEngine,
-    TransitionDelegate? transitionDelegate,
-    super.initialRoute,
-    super.restorationScopeId,
-  }) : super(
-          //keys should be optional
-          onPopPage: onPopPage ??
-              (route, result) {
-                final didPop = route.didPop(result);
-                if (!didPop) {
-                  return false;
-                }
-                return true;
-              },
-          onGenerateRoute: (settings) {
-            final selectedPageList =
-                pages.where((element) => element.name == settings.name);
-            if (selectedPageList.isNotEmpty) {
-              final selectedPage = selectedPageList.first;
-              return GetPageRoute(
-                page: selectedPage.page,
-                settings: settings,
-              );
-            }
-            return null;
-          },
-          observers: [
-            // GetObserver(),
-            ...?observers,
-          ],
-          transitionDelegate:
-              transitionDelegate ?? const DefaultTransitionDelegate<dynamic>(),
-        );
-
   GetNavigator({
     super.key,
     bool Function(Route<dynamic>, dynamic)? onPopPage,
-    required List<GetPage> super.pages,
+    required super.pages,
     List<NavigatorObserver>? observers,
     super.reportsRouteUpdateToEngine,
     TransitionDelegate? transitionDelegate,
     super.initialRoute,
     super.restorationScopeId,
   }) : super(
+          // ignore: deprecated_member_use
           onPopPage: onPopPage ??
               (route, result) {
                 final didPop = route.didPop(result);

lib/get_rx/src/rx_types/rx_core/rx_impl.dart

@@ -124,7 +124,7 @@ mixin RxObjectMixin<T> on GetListenable<T> {
     return subscription;
   }
 
-  /// Binds an existing `Stream<T>` to this Rx<T> to keep the values in sync.
+  /// Binds an existing `Stream<T>` to this `Rx<T>` to keep the values in sync.
   /// You can bind multiple sources to update the value.
   /// Closing the subscription will happen automatically when the observer
   /// Widget (`GetX` or `Obx`) gets unmounted from the Widget tree.
@@ -182,8 +182,8 @@ abstract class _RxImpl<T> extends GetListenable<T> with RxObjectMixin<T> {
   ///
   /// For example, supposed we have a `int seconds = 2` and we want to animate
   /// from invisible to visible a widget in two seconds:
-  /// RxEvent<int>.call(seconds);
-  /// then after a click happens, you want to call a RxEvent<int>.call(seconds).
+  /// `RxEvent<int>.call(seconds);`
+  /// then after a click happens, you want to call a `RxEvent<int>.call(seconds)`.
   /// By doing `call(seconds)`, if the value being held is the same,
   /// the listeners won't trigger, hence we need this new `trigger` function.
   /// This will refresh the listener of an AnimatedWidget and will keep

lib/get_rx/src/rx_types/rx_core/rx_interface.dart

@@ -2,7 +2,7 @@ part of '../rx_types.dart';
 
 /// This class is the foundation for all reactive (Rx) classes that makes Get
 /// so powerful.
-/// This interface is the contract that [_RxImpl]<T> uses in all it's
+/// This interface is the contract that `_RxImpl<T>` uses in all it's
 /// subclass.
 abstract class RxInterface<T> implements ValueListenable<T> {
   /// Close the Rx Variable

lib/get_rx/src/rx_types/rx_iterables/rx_list.dart

@@ -144,12 +144,7 @@ extension ListExtension<E> on List<E> {
     if (item != null) add(item);
   }
 
-  // /// Add [Iterable<E>] to [List<E>] only if [Iterable<E>] is not null.
-  // void addAllNonNull(Iterable<E> item) {
-  //   if (item != null) addAll(item);
-  // }
-
-  /// Add [item] to List<E> only if [condition] is true.
+  /// Add [item] to [List<E>] only if [condition] is true.
   void addIf(dynamic condition, E item) {
     if (condition is Condition) condition = condition();
     if (condition is bool && condition) add(item);

lib/get_state_manager/src/simple/get_view.dart

@@ -6,7 +6,7 @@ import 'get_state.dart';
 import 'get_widget_cache.dart';
 
 /// GetView is a great way of quickly access your Controller
-/// without having to call Get.find<AwesomeController>() yourself.
+/// without having to call `Get.find<AwesomeController>()` yourself.
 ///
 /// Sample:
 /// ```
@@ -43,7 +43,7 @@ abstract class GetView<T> extends StatelessWidget {
 }
 
 /// GetWidget is a great way of quickly access your individual Controller
-/// without having to call Get.find<AwesomeController>() yourself.
+/// without having to call `Get.find<AwesomeController>()` yourself.
 /// Get save you controller on cache, so, you can to use Get.create() safely
 /// GetWidget is perfect to multiples instance of a same controller. Each
 /// GetWidget will have your own controller, and will be call events as `onInit`

pubspec.yaml

@@ -1,6 +1,6 @@
 name: get
 description: Open screens/snackbars/dialogs without context, manage states and inject dependencies easily with GetX.
-version: 5.0.0-release-candidate-9.3.0
+version: 5.0.0-release-candidate-9.3.2
 homepage: https://github.com/jonataslaw/getx
 
 environment: