Update deprecated using ${var} (OpenMage#2611)

Author: sreichel

lib/Zend/Gdata/App.php

@@ -1084,11 +1084,11 @@ public function __call($method, $args)
             } else {
                 #require_once 'Zend/Gdata/App/Exception.php';
                 throw new Zend_Gdata_App_Exception(
-                        "Unable to find '${class}' in registered packages");
+                        "Unable to find '{$class}' in registered packages");
             }
         } else {
             #require_once 'Zend/Gdata/App/Exception.php';
-            throw new Zend_Gdata_App_Exception("No such method ${method}");
+            throw new Zend_Gdata_App_Exception("No such method {$method}");
         }
     }
 

lib/Zend/Gdata/App/Base.php

@@ -480,7 +480,7 @@ public function __get($name)
         $method = 'get'.ucfirst($name);
         if (method_exists($this, $method)) {
             return call_user_func(array(&$this, $method));
-        } else if (property_exists($this, "_${name}")) {
+        } else if (property_exists($this, "_{$name}")) {
             return $this->{'_' . $name};
         } else {
             #require_once 'Zend/Gdata/App/InvalidArgumentException.php';

lib/Zend/Gdata/App/BaseMediaSource.php

@@ -113,7 +113,7 @@ public function __get($name)
         $method = 'get'.ucfirst($name);
         if (method_exists($this, $method)) {
             return call_user_func(array(&$this, $method));
-        } else if (property_exists($this, "_${name}")) {
+        } else if (property_exists($this, "_{$name}")) {
             return $this->{'_' . $name};
         } else {
             #require_once 'Zend/Gdata/App/InvalidArgumentException.php';

lib/Zend/Gdata/App/LoggingHttpClientAdapterSocket.php

@@ -73,7 +73,7 @@ protected function log($message)
      */
     public function connect($host, $port = 80, $secure = false)
     {
-        $this->log("Connecting to: ${host}:${port}");
+        $this->log("Connecting to: {$host}:{$port}");
         return parent::connect($host, $port, $secure);
     }
 
@@ -102,7 +102,7 @@ public function write($method, $uri, $http_ver = '1.1', $headers = array(), $bod
     public function read()
     {
         $response = parent::read();
-        $this->log("${response}\n\n");
+        $this->log("{$response}\n\n");
         return $response;
     }
 

lib/Zend/Gdata/Gapps.php

@@ -879,7 +879,7 @@ public function __call($method, $args) {
             } else {
                 #require_once 'Zend/Gdata/App/Exception.php';
                 throw new Zend_Gdata_App_Exception(
-                        "Unable to find '${class}' in registered packages");
+                        "Unable to find '{$class}' in registered packages");
             }
         } else {
             return parent::__call($method, $args);