Suggestion to add some logging if in error (OpenMage#640)

seansan · web-flow · commit e055833bd282 · 2021-05-16T11:24:54.000+02:00
Suggestion to add some logging if in error https://community.magento.com/t5/Payments-PayPal/PayPal-response-hasn-t-required-fields-AMT-field-is-deprecated/td-p/51852
diff --git a/app/code/core/Mage/Paypal/Model/Api/Nvp.php b/app/code/core/Mage/Paypal/Model/Api/Nvp.php
@@ -1164,6 +1164,7 @@ protected function _validateResponse($method, $response)
         if (isset($this->_requiredResponseParams[$method])) {
             foreach ($this->_requiredResponseParams[$method] as $param) {
                 if (!isset($response[$param])) {
+                    Mage::log("Expected PayPal field not found in NVP Response: $param");
                     return false;
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -1164,6 +1164,7 @@ protected function _validateResponse($method, $response)`
`1164`	`1164`	`if (isset($this->_requiredResponseParams[$method])) {`
`1165`	`1165`	`foreach ($this->_requiredResponseParams[$method] as $param) {`
`1166`	`1166`	`if (!isset($response[$param])) {`
	`1167`	`+ Mage::log("Expected PayPal field not found in NVP Response: $param");`
`1167`	`1168`	`return false;`
`1168`	`1169`	`}`
`1169`	`1170`	`}`