Some fixes for phpdocs (OpenMage#2588)

* Some phpdocs updates

* Minor fixes

Co-authored-by: Fabrizio Balliano <fabrizio.balliano@gmail.com>

Author: sreichel

app/code/core/Mage/Admin/Model/Acl/Assert/Ip.php

@@ -31,10 +31,10 @@ class Mage_Admin_Model_Acl_Assert_Ip implements Zend_Acl_Assert_Interface
      * Check whether ip is allowed
      *
      * @param Mage_Admin_Model_Acl $acl
-     * @param Mage_Admin_Model_Acl_Role $role
-     * @param Mage_Admin_Model_Acl_Resource $resource
-     * @param string $privilege
-     * @return bool
+     * @param Mage_Admin_Model_Acl_Role|null $role
+     * @param Mage_Admin_Model_Acl_Resource|null $resource
+     * @param string|null $privilege
+     * @return bool|null
      */
     public function assert(
         Mage_Admin_Model_Acl $acl,

app/code/core/Mage/Admin/Model/Acl/Assert/Time.php

@@ -31,10 +31,10 @@ class Mage_Admin_Model_Acl_Assert_Time implements Zend_Acl_Assert_Interface
      * Assert time
      *
      * @param Mage_Admin_Model_Acl $acl
-     * @param Mage_Admin_Model_Acl_Role $role
-     * @param Mage_Admin_Model_Acl_Resource $resource
-     * @param string $privilege
-     * @return bool
+     * @param Mage_Admin_Model_Acl_Role|null $role
+     * @param Mage_Admin_Model_Acl_Resource|null $resource
+     * @param string|null $privilege
+     * @return bool|null
      */
     public function assert(
         Mage_Admin_Model_Acl $acl,

app/code/core/Mage/Admin/Model/Redirectpolicy.php

@@ -45,7 +45,7 @@ public function __construct($parameters = [])
      * Redirect to startup page after logging in if request contains any params (except security key)
      *
      * @param Mage_Admin_Model_User $user
-     * @param Zend_Controller_Request_Http $request
+     * @param Zend_Controller_Request_Http|null $request
      * @param string|null $alternativeUrl
      * @return null|string
      */

app/code/core/Mage/Adminhtml/Block/Catalog/Product/Composite/Configure.php

@@ -57,7 +57,7 @@ public function getProduct()
     /**
      * Set product object
      *
-     * @param Mage_Catalog_Model_Product $product
+     * @param Mage_Catalog_Model_Product|null $product
      * @return $this
      */
     public function setProduct(Mage_Catalog_Model_Product $product = null)

app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/Wishlist.php

@@ -192,7 +192,6 @@ public function getGridUrl()
      */
     protected function _addColumnFilterToCollection($column)
     {
-        /** @var Mage_Wishlist_Model_Resource_Item_Collection $collection */
         $collection = $this->getCollection();
         $value = $column->getFilter()->getValue();
         if ($collection && $value) {

app/code/core/Mage/Adminhtml/Block/System/Config/Form/Field/Array/Abstract.php

@@ -135,7 +135,7 @@ public function getArrayRows()
             return $this->_arrayRowsCache;
         }
         $result = [];
-        /** @var Varien_Data_Form_Element_Abstract */
+        /** @var Varien_Data_Form_Element_Abstract $element */
         $element = $this->getElement();
         if ($element->getValue() && is_array($element->getValue())) {
             foreach ($element->getValue() as $rowId => $row) {

app/code/core/Mage/Adminhtml/Block/System/Convert/Gui/Edit/Tabs.php

@@ -67,8 +67,7 @@ protected function _beforeToHtml()
                 'content'   => $this->getLayout()->createBlock('adminhtml/system_convert_profile_edit_tab_run')->toHtml(),
             ]);
 
-            /** @var Mage_Adminhtml_Block_System_Convert_Gui_Edit_Tab_View
-            $block */
+            /** @var Mage_Adminhtml_Block_System_Convert_Gui_Edit_Tab_View $block */
             $block = $this->getLayout()->createBlock('adminhtml/system_convert_gui_edit_tab_view');
             $this->addTab('view', [
                 'label'     => Mage::helper('adminhtml')->__('Profile Actions XML'),

app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php

@@ -1663,7 +1663,7 @@ protected function _getNewCustomerEmail($customer)
     protected function _putCustomerIntoQuote()
     {
         if (!$this->getSession()->getCustomer()->getId()) {
-            /** @var Mage_Customer_Model_Customer*/
+            /** @var Mage_Customer_Model_Customer $customer */
             $customer = Mage::getModel('customer/customer');
 
             $customer->addData($this->getBillingAddress()->exportCustomerAddress()->getData())

app/code/core/Mage/Adminhtml/controllers/Sales/Order/CreateController.php

@@ -475,8 +475,6 @@ public function cancelAction()
 
     /**
      * Saving quote and create order
-     *
-     * @throws Mage_Core_Exception
      */
     public function saveAction()
     {

app/code/core/Mage/Api/Model/Acl/Assert/Ip.php

@@ -31,10 +31,10 @@ class Mage_Api_Model_Acl_Assert_Ip implements Zend_Acl_Assert_Interface
      * Check whether ip is allowed
      *
      * @param Mage_Api_Model_Acl $acl
-     * @param Mage_Api_Model_Acl_Role $role
-     * @param Mage_Api_Model_Acl_Resource $resource
-     * @param string $privilege
-     * @return bool
+     * @param Mage_Api_Model_Acl_Role|null $role
+     * @param Mage_Api_Model_Acl_Resource|null $resource
+     * @param string|null $privilege
+     * @return bool|null
      */
     public function assert(
         Mage_Api_Model_Acl $acl,