Replace Date Format String Literals With Existing Constants (OpenMage#2592)

Author: Sdfendor

app/code/core/Mage/AdminNotification/Model/Feed.php

@@ -103,7 +103,7 @@ public function checkUpdate()
      */
     public function getDate($rssDate)
     {
-        return gmdate('Y-m-d H:i:s', strtotime($rssDate));
+        return gmdate(Varien_Db_Adapter_Pdo_Mysql::TIMESTAMP_FORMAT, strtotime($rssDate));
     }
 
     /**

app/code/core/Mage/AdminNotification/Model/Inbox.php

@@ -128,7 +128,7 @@ public function add($severity, $title, $description, $url = '', $isInternal = tr
         if (is_array($description)) {
             $description = '<ul><li>' . implode('</li><li>', $description) . '</li></ul>';
         }
-        $date = date('Y-m-d H:i:s');
+        $date = date(Varien_Db_Adapter_Pdo_Mysql::TIMESTAMP_FORMAT);
         $this->parse([[
             'severity'    => $severity,
             'date_added'  => $date,

app/code/core/Mage/Adminhtml/Block/Sitemap/Grid/Renderer/Time.php

@@ -35,6 +35,9 @@ class Mage_Adminhtml_Block_Sitemap_Grid_Renderer_Time extends Mage_Adminhtml_Blo
      */
     public function render(Varien_Object $row)
     {
-        return date('Y-m-d H:i:s', strtotime($row->getSitemapTime()) + Mage::getSingleton('core/date')->getGmtOffset());
+        return date(
+            Varien_Date::DATETIME_PHP_FORMAT,
+            strtotime($row->getSitemapTime()) + Mage::getSingleton('core/date')->getGmtOffset()
+        );
     }
 }

app/code/core/Mage/Adminhtml/Model/Sales/Order/Random.php

@@ -149,7 +149,7 @@ public function render()
     protected function _getRandomDate()
     {
         $timestamp = mktime(rand(0, 23), rand(0, 59), 0, rand(1, 11), rand(1, 28), rand(2006, 2007));
-        return date('Y-m-d H:i:s', $timestamp);
+        return date(Varien_Date::DATETIME_PHP_FORMAT, $timestamp);
     }
 
     public function save()

app/code/core/Mage/Core/Model/Date.php

@@ -98,7 +98,7 @@ public function calculateOffset($timezone = null)
     public function gmtDate($format = null, $input = null)
     {
         if (is_null($format)) {
-            $format = 'Y-m-d H:i:s';
+            $format = Varien_Date::DATETIME_PHP_FORMAT;
         }
 
         $date = $this->gmtTimestamp($input);
@@ -121,7 +121,7 @@ public function gmtDate($format = null, $input = null)
     public function date($format = null, $input = null)
     {
         if (is_null($format)) {
-            $format = 'Y-m-d H:i:s';
+            $format = Varien_Date::DATETIME_PHP_FORMAT;
         }
 
         return date($format, $this->timestamp($input));

app/code/core/Mage/Core/Model/Flag.php

@@ -67,7 +67,7 @@ protected function _beforeSave()
         }
 
         $this->setFlagCode($this->_flagCode);
-        $this->setLastUpdate(date('Y-m-d H:i:s'));
+        $this->setLastUpdate(date(Varien_Db_Adapter_Pdo_Mysql::TIMESTAMP_FORMAT));
 
         return parent::_beforeSave();
     }

app/code/core/Mage/Core/Model/Locale.php

@@ -591,7 +591,7 @@ public function storeTimeStamp($store = null)
         $timezone = Mage::app()->getStore($store)->getConfig(self::XML_PATH_DEFAULT_TIMEZONE);
         $currentTimezone = @date_default_timezone_get();
         @date_default_timezone_set($timezone);
-        $date = date('Y-m-d H:i:s');
+        $date = date(Varien_Date::DATETIME_PHP_FORMAT);
         @date_default_timezone_set($currentTimezone);
         return strtotime($date);
     }

app/code/core/Mage/Core/Model/Observer.php

@@ -67,7 +67,7 @@ public function addSynchronizeNotification(Varien_Event_Observer $observer)
                     $description    = Mage::helper('adminhtml')->__('Synchronization of media storages has been successfully completed.');
                 }
 
-                $date = date('Y-m-d H:i:s');
+                $date = date(Varien_Db_Adapter_Pdo_Mysql::TIMESTAMP_FORMAT);
                 Mage::getModel('adminnotification/inbox')->parse([
                     [
                         'severity'      => $severity,

app/code/core/Mage/Dataflow/Model/Convert/Adapter/Http.php

@@ -72,7 +72,7 @@ public function loadFile()
             $uploader->save($path);
             if ($uploadFile = $uploader->getUploadedFileName()) {
                 $session = Mage::getModel('dataflow/session');
-                $session->setCreatedDate(date('Y-m-d H:i:s'));
+                $session->setCreatedDate(date(Varien_Date::DATETIME_PHP_FORMAT));
                 $session->setDirection('import');
                 $session->setUserId(Mage::getSingleton('admin/session')->getUser()->getId());
                 $session->save();

app/code/core/Mage/Dataflow/Model/Session/Adapter/Http.php

@@ -45,7 +45,7 @@ public function load()
             $uploader->save($path);
             if ($uploadFile = $uploader->getUploadedFileName()) {
                 $session = Mage::getModel('dataflow/session');
-                $session->setCreatedDate(date('Y-m-d H:i:s'));
+                $session->setCreatedDate(date(Varien_Date::DATETIME_PHP_FORMAT));
                 $session->setDirection('import');
                 $session->setUserId(Mage::getSingleton('admin/session')->getUser()->getId());
                 $session->save();