Optimize EAV collections (OpenMage#911)

Sekiphp · kiatng · colinmollenhour · web-flow · commit 2946fcbf61e6 · 2022-09-28T03:04:05.000+02:00
* Optimize loading of EAV collections - remove filter of entity_type_id

* Optimize EAV collections - entity

* Update app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php

Co-authored-by: Colin Mollenhour &lt;colin@mollenhour.com&gt;

* Update app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php

Co-authored-by: Ng Kiat Siong &lt;kiatsiong.ng@gmail.com&gt;
Co-authored-by: Colin Mollenhour &lt;colin@mollenhour.com&gt;
diff --git a/app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php b/app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php
@@ -160,9 +160,11 @@ protected function _prepareStaticFields()
     protected function _initSelect()
     {
         $this->getSelect()->from(['e' => $this->getEntity()->getEntityTable()]);
-        if ($this->getEntity()->getTypeId()) {
+
+        if ($this->getEntity()->getEntityTable() === Mage_Eav_Model_Entity::DEFAULT_ENTITY_TABLE && $this->getEntity()->getTypeId()) {
             $this->addAttributeToFilter('entity_type_id', $this->getEntity()->getTypeId());
         }
+        
         return $this;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -160,9 +160,11 @@ protected function _prepareStaticFields()`
`160`	`160`	`protected function _initSelect()`
`161`	`161`	`{`
`162`	`162`	`$this->getSelect()->from(['e' => $this->getEntity()->getEntityTable()]);`
`163`		`- if ($this->getEntity()->getTypeId()) {`
	`163`	`+`
	`164`	`+ if ($this->getEntity()->getEntityTable() === Mage_Eav_Model_Entity::DEFAULT_ENTITY_TABLE && $this->getEntity()->getTypeId()) {`
`164`	`165`	`$this->addAttributeToFilter('entity_type_id', $this->getEntity()->getTypeId());`
`165`	`166`	`}`
	`167`	`+`
`166`	`168`	`return $this;`
`167`	`169`	`}`
`168`	`170`