`castor execute` causes PHP out of memory error

[TheoD02]

Description

Running the command castor execute symplify/easy-coding-standard results in a PHP fatal error due to memory exhaustion.

Error Message

castor execute symplify/easy-coding-standard
PHP Fatal error:  Allowed memory size of 134217728 bytes exhausted (tried to allocate 20480 bytes) in phar:///Users/theod/.local/bin/castor/vendor/composer/composer/src/Composer/DependencyResolver/PoolOptimizer.php on line 232

Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 20480 bytes) in phar:///Users/theod/.local/bin/castor/vendor/composer/composer/src/Composer/DependencyResolver/PoolOptimizer.php on line 232
16:38:49 ERROR     [castor] Fatal Error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 20480 bytes) ["exception" => Symfony\Component\ErrorHandler\Error\OutOfMemoryError^ { …}]
Symfony\Component\ErrorHandler\Error\OutOfMemoryError^ {#127090
  #message: "Error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 20480 bytes)"
  #code: 0
  #file: "phar:///Users/theod/.local/bin/castor/vendor/composer/composer/src/Composer/DependencyResolver/PoolOptimizer.php"
  #line: 232
  -error: array:4 [
    "type" => 1
    "message" => "Allowed memory size of 134217728 bytes exhausted (tried to allocate 20480 bytes)"
    "file" => "phar:///Users/theod/.local/bin/castor/vendor/composer/composer/src/Composer/DependencyResolver/PoolOptimizer.php"
    "line" => 232
  ]
}

Check https://getcomposer.org/doc/articles/troubleshooting.md#memory-limit-errors for more info on how to handle out of memory errors.⏎  

Steps to Reproduce

1. Run the command:

   castor execute symplify/easy-coding-standard

[lyrixx]

What happens when you run composer req symplify/easy-coding-standard --no-interaction in a blank directory?

[TheoD02]

Similar error

Changing the value of my php.ini fix the issue when using the pharversion, but if I use the static version, the issue is still present

[lyrixx]

Similar error

okay, so it looks like there is an issue in composer. And we can't do anything.

Changing the value of my php.ini fix the issue when using the pharversion, but if I use the static version, the issue is still present

It's possible to change the value in the compiled version:

$ castor compile --help
Usage:
  castor:compile [options] [--] <phar-path>
  compile

Arguments:
  phar-path                            Path to phar to compile along PHP

Options:
[...]
  -N, --php-ini-file=PHP-INI-FILE      ini file to inject into micro.sfx when combining

Maybe we could deliver a static binary with more memory available

[TheoD02]

Yes we can consider deliver a static binary with more memory available

Another option is to support an environment variable like PHP_MEMORY_LIMIT, which would allow users to adjust memory limits without modifying the compiled version of castor, or declare manually via ini_set() in castor.php directly (tested , work fine) in case we want to use it standalone without creating a root castor.php

For example:

✅ Option 1: Using ini_set() in the root castor.php

If using a root-level castor.php, we can manually set the memory limit like this:

<?php

ini_set('memory_limit', '1G');

// ... the rest of your castor script

✅ Option 2: Using an environment variable (standalone-friendly)

PHP_MEMORY_LIMIT=1G castor execute symplify/easy-coding-standard

Internally, castor would detect this and call ini_set('memory_limit', $_ENV['PHP_MEMORY_LIMIT']) early in the execution process if PHP_MEMORY_LIMIT is set

This would enable both standalone and castor.php based

Happy to open a PR if this direction makes sense, WDYT?

[lyrixx]

Can you try again with CASTOR_MEMORY_LIMIT=2G castor .... ?

ref: https://github.com/jolicode/castor/blob/main/bin/castor#L10C30-L10C49

I think it won't work, since we embed composer, so we don't go through the if

[TheoD02]

Can you try again with CASTOR_MEMORY_LIMIT=2G castor .... ?

ref: https://github.com/jolicode/castor/blob/main/bin/castor#L10C30-L10C49

I think it won't work, since we embed composer, so we don't go through the if

$phpFile = $_SERVER['CASTOR_PHP_REPLACE'] ?? false;

+$memoryLimit = $_SERVER['CASTOR_MEMORY_LIMIT'] ?? false;
+
+if ($memoryLimit && function_exists('ini_set')) {
+    ini_set('memory_limit', $memoryLimit);
+}

if ($phpFile) {
-    $memoryLimit = $_SERVER['CASTOR_MEMORY_LIMIT'] ?? false;
-
-    if ($memoryLimit && function_exists('ini_set')) {
-        ini_set('memory_limit', $memoryLimit);
-    }

    require $phpFile;

    exit(0);
}

Tested with this change and by running CASTOR_MEMORY_LIMIT=2G ~/workspaces/perso/castor/bin/castor execute symplify/easy-coding-standard it's work, but didn't tested with static version yet