* Fixed bug in __isset magic method.

Author: jlorente

src/ActiveRecordInheritanceTrait.php

@@ -73,7 +73,8 @@
  * 
  * @author José Lorente <jose.lorente.martin@gmail.com>
  */
-trait ActiveRecordInheritanceTrait {
+trait ActiveRecordInheritanceTrait
+{
 
     /**
      *
@@ -84,7 +85,8 @@ trait ActiveRecordInheritanceTrait {
     /**
      * @return \yii\db\ActiveRecordInterface
      */
-    public function getParent($recalculate = false) {
+    public function getParent($recalculate = false)
+    {
         if ($this->_parent === null || $recalculate === true) {
             if (($this instanceof ActiveRecordInheritanceInterface) === false) {
                 throw new BaseException('Classes that use the \jlorente\db\ActiveRecordInheritanceTrait must implement \jlorente\db\ActiveRecordInheritanceInterface');
@@ -105,23 +107,26 @@ public function getParent($recalculate = false) {
      * 
      * @return \yii\db\ActiveQueryInterface
      */
-    private function _parent() {
+    private function _parent()
+    {
         $class = static::extendsFrom();
         return $this->hasOne($class::className(), [$this->parentPrimaryKey() => $this->parentAttribute()]);
     }
 
     /**
      * @inheritdoc
      */
-    public static function populateRecord($record, $row) {
+    public static function populateRecord($record, $row)
+    {
         parent::populateRecord($record, $row);
         $record->_parent = $record->_parent()->one();
     }
 
     /**
      * @inheritdoc
      */
-    public function __get($name) {
+    public function __get($name)
+    {
         try {
             return parent::__get($name);
         } catch (UnknownPropertyException $e) {
@@ -132,7 +137,8 @@ public function __get($name) {
     /**
      * @inheritdoc
      */
-    public function __set($name, $value) {
+    public function __set($name, $value)
+    {
         try {
             parent::__set($name, $value);
         } catch (UnknownPropertyException $e) {
@@ -147,21 +153,23 @@ public function __set($name, $value) {
     /**
      * @inheritdoc
      */
-    public function setAttributes($values, $safeOnly = true) {
+    public function setAttributes($values, $safeOnly = true)
+    {
         $this->getParent()->setAttributes($values, $safeOnly);
         parent::setAttributes($values, $safeOnly);
     }
 
     /**
      * @inheritdoc
      */
-    public function __isset($name) {
+    public function __isset($name)
+    {
         try {
             if (parent::__get($name) !== null) {
                 return true;
             }
         } catch (UnknownPropertyException $e) {
-            return $this->getParent()->{$name};
+            return isset($this->getParent()->{$name});
         }
 
         if (parent::__isset($name) === false) {
@@ -174,7 +182,8 @@ public function __isset($name) {
     /**
      * @inheritdoc
      */
-    public function __unset($name) {
+    public function __unset($name)
+    {
         try {
             if (parent::__get($name) !== null) {
                 parent::__unset($name);
@@ -187,7 +196,8 @@ public function __unset($name) {
     /**
      * @inheritdoc
      */
-    public function __call($name, $params) {
+    public function __call($name, $params)
+    {
         try {
             return parent::__call($name, $params);
         } catch (UnknownMethodException $e) {
@@ -210,7 +220,8 @@ public function __call($name, $params) {
      * 
      * ```
      */
-    public function attributeLabels() {
+    public function attributeLabels()
+    {
         return array_merge($this->getParent()->attributeLabels(), parent::attributeLabels());
     }
 
@@ -223,7 +234,8 @@ public function attributeLabels() {
      * @param array $except list of attributes whose value should NOT be returned.
      * @return array attribute values (name => value).
      */
-    public function getAttributes($names = null, $except = array()) {
+    public function getAttributes($names = null, $except = array())
+    {
         if ($names === null) {
             $names = array_merge($this->getParent()->attributes(), $this->attributes());
         }
@@ -238,7 +250,8 @@ public function getAttributes($names = null, $except = array()) {
      * @return boolean
      * @throws \Exception
      */
-    public function save($runValidation = true, $attributeNames = null) {
+    public function save($runValidation = true, $attributeNames = null)
+    {
         if ($runValidation === true && $this->validate($attributeNames) === false) {
             Yii::info('Model not inserted due to validation error.', __METHOD__);
             return false;
@@ -281,7 +294,8 @@ public function save($runValidation = true, $attributeNames = null) {
      * being deleted is outdated.
      * @throws \Exception in case delete failed.
      */
-    public function delete() {
+    public function delete()
+    {
         $trans = static::getDb()->beginTransaction();
         try {
             if (parent::delete() === false) {
@@ -307,10 +321,11 @@ public function delete() {
      * @return boolean
      * @throws Exception
      */
-    public function validate($attributeNames = null, $clearErrors = true) {
+    public function validate($attributeNames = null, $clearErrors = true)
+    {
         $r = parent::validate($attributeNames === null ?
-                                array_diff($this->activeAttributes(), $this->getParent()->activeAttributes(), [$this->parentAttribute()]) :
-                                $attributeNames, $clearErrors);
+                        array_diff($this->activeAttributes(), $this->getParent()->activeAttributes(), [$this->parentAttribute()]) :
+                        $attributeNames, $clearErrors);
         return $this->getParent()->validate($attributeNames, $clearErrors) && $r;
     }
 
@@ -322,7 +337,8 @@ public function validate($attributeNames = null, $clearErrors = true) {
      * @param string|null $attribute attribute name. Use null to check all attributes.
      * @return boolean whether there is any error.
      */
-    public function hasErrors($attribute = null) {
+    public function hasErrors($attribute = null)
+    {
         return $this->getParent()->hasErrors($attribute) || parent::hasErrors($attribute);
     }
 
@@ -352,7 +368,8 @@ public function hasErrors($attribute = null) {
      * @see getFirstErrors()
      * @see getFirstError()
      */
-    public function getErrors($attribute = null) {
+    public function getErrors($attribute = null)
+    {
         return array_merge($this->getParent()->getErrors($attribute), parent::getErrors($attribute));
     }
 
@@ -366,7 +383,8 @@ public function getErrors($attribute = null) {
      * @see getErrors()
      * @see getFirstError()
      */
-    public function getFirstErrors() {
+    public function getFirstErrors()
+    {
         $errs = $this->getErrors();
         if (empty($errs)) {
             return [];
@@ -392,15 +410,17 @@ public function getFirstErrors() {
      * @see getErrors()
      * @see getFirstErrors()
      */
-    public function getFirstError($attribute) {
+    public function getFirstError($attribute)
+    {
         $errors = $this->getErrors($attribute);
         return count($errors) ? $errors[0] : null;
     }
 
     /**
      * @inheritdoc
      */
-    public function refresh() {
+    public function refresh()
+    {
         $r = parent::refresh();
         return $this->getParent()->refresh() && $r;
     }
@@ -411,7 +431,8 @@ public function refresh() {
      * 
      * @return string
      */
-    public function parentAttribute() {
+    public function parentAttribute()
+    {
         return static::primaryKey()[0];
     }
 
@@ -420,22 +441,25 @@ public function parentAttribute() {
      * 
      * @return string
      */
-    public function parentPrimaryKey() {
+    public function parentPrimaryKey()
+    {
         $pClass = static::extendsFrom();
         return $pClass::primaryKey()[0];
     }
 
     /**
      * @inheritdoc
      */
-    public function fields() {
+    public function fields()
+    {
         return ArrayHelper::merge($this->parent->fields(), parent::fields());
     }
 
     /**
      * @inheritdoc
      */
-    public function loadDefaultValues($skipIfSet = true) {
+    public function loadDefaultValues($skipIfSet = true)
+    {
         $this->parent->loadDefaultValues($skipIfSet);
         parent::loadDefaultValues($skipIfSet);
     }