Skip to content

Commit 4421ca1

Browse files
authored
Merge pull request #17 from jkaninda/develop
Refactoring of code
2 parents 7dc7c42 + aafe505 commit 4421ca1

File tree

3 files changed

+4
-8
lines changed

3 files changed

+4
-8
lines changed

README.md

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@ MySQL Backup tool, backup database to S3 or Object Storage
1313
- [Docker Hub](https://hub.docker.com/r/jkaninda/mysql-bkup)
1414
- [Github](https://github.com/jkaninda/mysql-bkup)
1515

16-
## Postgres solution :
16+
## PostgreSQL solution :
1717

18-
- [Postgress](https://github.com/jkaninda/pg-bkup)
18+
- [PostgreSQL](https://github.com/jkaninda/pg-bkup)
1919

2020

2121

@@ -237,7 +237,7 @@ Easy to remember format:
237237
> Docker run :
238238
239239
```sh
240-
docker run --rm --name mysql-bkup -v $BACKUP_DIR:/backup/ -e "DB_HOST=$DB_HOST" -e "DB_USERNAME=$DB_USERNAME" -e "DB_PASSWORD=$DB_PASSWORD" jkaninda/mysql-bkup:latest bkup --operation backup --dbname $DB_NAME --mode scheduled --period "0 1 * * *"
240+
docker run --rm --name mysql-bkup -v $BACKUP_DIR:/backup/ -e "DB_HOST=$DB_HOST" -e "DB_USERNAME=$DB_USERNAME" -e "DB_PASSWORD=$DB_PASSWORD" jkaninda/mysql-bkup bkup --operation backup --dbname $DB_NAME --mode scheduled --period "0 1 * * *"
241241
```
242242

243243
> With Docker compose
@@ -246,7 +246,7 @@ docker run --rm --name mysql-bkup -v $BACKUP_DIR:/backup/ -e "DB_HOST=$DB_HOST"
246246
version: "3"
247247
services:
248248
mysql-bkup:
249-
image: jkaninda/mysql-bkup:v0.3
249+
image: jkaninda/mysql-bkup
250250
container_name: mysql-bkup
251251
privileged: true
252252
devices:
@@ -283,7 +283,6 @@ spec:
283283
spec:
284284
template:
285285
spec:
286-
backoffLimit: 2
287286
containers:
288287
- name: mysql-bkup
289288
image: jkaninda/mysql-bkup

k8s-job.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ spec:
88
spec:
99
template:
1010
spec:
11-
backoffLimit: 2
1211
containers:
1312
- name: mysql-bkup
1413
image: jkaninda/mysql-bkup

src/docker/Dockerfile

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,7 @@ ENV DB_NAME=""
44
ENV DB_USERNAME=""
55
ENV DB_PASSWORD=""
66
ENV DB_PORT="3306"
7-
ENV DESTINATION=local
87
ENV STORAGE=local
9-
ENV SOURCE=local
108
ENV BUCKETNAME=""
119
ENV ACCESS_KEY=""
1210
ENV SECRET_KEY=""

0 commit comments

Comments
 (0)