Merge pull request #10 from jjs-dev/warnings

Deny rustc warnings

Author: MikailBag

.github/workflows/rust.yml

@@ -27,12 +27,12 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions-rs/toolchain@v1.0.6
         with:
-          toolchain: stable
+          toolchain: nightly
           components: clippy
+          override: true
       - name: Run clippy
         run: |
-          rm -rf .cargo
-          cargo clippy -p minion -p minion-ffi -p minion-cli -- -Dclippy::all
+          cargo clippy --workspace -- -Dclippy::all -Dwarnings
   check-platform-support:
     runs-on: ubuntu-latest
     steps:

minion-tests/src/tests/simple.rs

@@ -1,6 +1,5 @@
 //! Tests that simple program that does nothing completes successfully.
 use minion::ChildProcess;
-use minion::Dominion;
 
 pub(crate) struct TOk;
 impl crate::TestCase for TOk {
@@ -126,7 +125,7 @@ impl crate::TestCase for TOom {
         }
     }
 
-    fn check(&self, cp: &mut dyn ChildProcess, d: minion::DominionRef) {
+    fn check(&self, _cp: &mut dyn ChildProcess, _d: minion::DominionRef) {
         // TODO this test is broken
         // super::assert_exit_code(cp, -9);
         // assert!(!d.check_cpu_tle().unwrap());
@@ -165,7 +164,7 @@ impl crate::TestCase for TSecurity {
         assert!(matches!(err, nix::Error::Sys(nix::errno::Errno::EPERM)));
         std::process::exit(24)
     }
-    fn check(&self, cp: &mut dyn minion::ChildProcess, d: minion::DominionRef) {
+    fn check(&self, cp: &mut dyn minion::ChildProcess, _d: minion::DominionRef) {
         super::assert_exit_code(cp, 24);
         super::assert_empty(&mut cp.stdout().unwrap());
         super::assert_empty(&mut cp.stderr().unwrap());