Update versions, add new dashboards and improve formatting #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…HA capability is built into it)
…HA capability is built into it)
eldada
changed the title
Collaborator
this unncessary widget should be removed.
|
Contributor
Author
For now, I'll leave it alone. Seems this is an internal Loki validation flow. |
prathyu1729
approved these changes
Sep 8, 2025
helm/artifactory-values.yaml
Outdated
| value: {{ .Values.artifactory.persistence.mountPath }} | ||
| - name: LOKI_URL | ||
| value: http://loki.{{ .Release.Namespace }}:3100 | ||
| value: http://loki.monitoring.svc.cluster.local:3100 |
Collaborator
There was a problem hiding this comment.
This monitoring seems to be hardcoded here.
People have option to change this:
export OBS_NAMESPACE=monitoring
Can we please take care of this?
helm/xray-values.yaml
Outdated
| value: ../../../..{{ .Values.xray.persistence.mountPath }}/etc/fluentd/fluentd.conf | ||
| - name: LOKI_URL | ||
| value: http://loki.{{ .Release.Namespace }}:3100 | ||
| value: http://loki.monitoring.svc.cluster.local:3100 |
Collaborator
There was a problem hiding this comment.
Here also, monitoring is hardcoded.
deepakkjfrog
approved these changes
Sep 30, 2025
jf-Harsh
approved these changes
Oct 9, 2025
shraddha5718
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.