Skip to content

Commit bd4ef03

Browse files
forgotjevonmao
andauthored
Make EventKit Imports Explicit (#149)
* Add PERMISSIONSWIFTUI_EVENT SwiftSetting definition to JMRemindersPermissionManager and JMCalendarPermissionManager target definitions. * Wrap EventPermissionManager, JMRemindersPermissionManager, and JMCalendarPermissionManager with PERMISSIONSWIFTUI_EVENT check --------- Co-authored-by: Jevon Mao <woodburyjevonmao@gmail.com>
1 parent f33413e commit bd4ef03

File tree

4 files changed

+15
-6
lines changed

4 files changed

+15
-6
lines changed

Package.swift

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,10 @@ let permissionsTargets: [Target] = [
2323
.target(
2424
name: "PermissionsSwiftUICalendar",
2525
dependencies: ["Introspect", "CorePermissionsSwiftUI"],
26-
exclude: ["../../Tests/PermissionsSwiftUITests/__Snapshots__"]
26+
exclude: ["../../Tests/PermissionsSwiftUITests/__Snapshots__"],
27+
swiftSettings: [
28+
.define("PERMISSIONSWIFTUI_EVENT")
29+
]
2730
),
2831
.target(
2932
name: "PermissionsSwiftUICamera",
@@ -93,7 +96,10 @@ let permissionsTargets: [Target] = [
9396
.target(
9497
name: "PermissionsSwiftUIReminder",
9598
dependencies: ["Introspect", "CorePermissionsSwiftUI"],
96-
exclude: ["../../Tests/PermissionsSwiftUITests/__Snapshots__"]
99+
exclude: ["../../Tests/PermissionsSwiftUITests/__Snapshots__"],
100+
swiftSettings: [
101+
.define("PERMISSIONSWIFTUI_EVENT")
102+
]
97103
),
98104
.target(
99105
name: "PermissionsSwiftUISpeech",
@@ -142,4 +148,4 @@ let package = Package(
142148
),
143149

144150
] + permissionsTargets
145-
)
151+
)

Sources/CorePermissionsSwiftUI/Model/PermissionManagers/EventPermissionManager.swift

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66
//
77

88
import Foundation
9+
10+
#if !os(tvOS) && PERMISSIONSWIFTUI_EVENT
911
import EventKit
1012

1113
open class EventPermissionManager: PermissionManager {
@@ -52,3 +54,4 @@ open class EventPermissionManager: PermissionManager {
5254
}
5355

5456
}
57+
#endif

Sources/PermissionsSwiftUICalendar/JMCalendarPermissionManager.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
// Created by Jevon Mao on 1/31/21.
66
//
77

8-
import UIKit
9-
#if !os(tvOS)
8+
import Foundation
9+
#if !os(tvOS) && PERMISSIONSWIFTUI_EVENT
1010
import EventKit
1111
import CorePermissionsSwiftUI
1212

Sources/PermissionsSwiftUIReminder/JMRemindersPermissionManager.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
//
77

88
import Foundation
9-
#if !os(tvOS)
9+
#if !os(tvOS) && PERMISSIONSWIFTUI_EVENT
1010
import EventKit
1111
import CorePermissionsSwiftUI
1212

0 commit comments

Comments
 (0)