Skip to content

Commit 5d1bd87

Browse files
committed
disable the dump of the config file on startup
The config is also no longer dumped at startup. I don't think there is a point in dumping the whole content of a file... it's super verbose and is even hurtful as it drowns actual important errors within a flow of log lines. If we think that dumping the config is an important feature, it should be gated behind a --debug flag. I propose to remove it for now.
1 parent 1459adf commit 5d1bd87

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

pkg/agent/run.go

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -261,13 +261,6 @@ func getConfiguration() (Config, client.Client) {
261261
logs.Log.Fatalf("Failed to load period, must be set as flag or in config")
262262
}
263263

264-
dump, err := config.Dump()
265-
if err != nil {
266-
logs.Log.Fatalf("Failed to dump config: %s", err)
267-
}
268-
269-
logs.Log.Printf("Loaded config: \n%s", dump)
270-
271264
var credentials client.Credentials
272265
if ClientID != "" {
273266
credentials = &client.VenafiSvcAccountCredentials{

0 commit comments

Comments
 (0)