bugfix: clear cache after switching the locale

Author: hamidgh83

src/Traits/TranslatableTrait.php

@@ -97,6 +97,36 @@ private function isTranslatableAttribute(string $key): bool
      */
     private function getCachedTranslations(): Collection
     {
-        return $this->cachedTranslationModels = $this->cachedTranslationModels ?: $this->translation()->locale(app()->getLocale())->get();
+        // Check if translations are already cached for the current locale
+        if ($this->cachedTranslationModels instanceof Collection && $this->hasTranslationsForCurrentLocale()) {
+            return $this->cachedTranslationModels;
+        }
+
+        // If not cached or not found for current locale, fetch and cache translations
+        return $this->cachedTranslationModels = $this->fetchAndCacheTranslations(app()->getLocale());
+    }
+
+    /**
+     * Determines whether there are any translations cached for the current locale.
+     *
+     * @return bool `true` if there are cached translations for the current locale, `false` otherwise
+     */
+    private function hasTranslationsForCurrentLocale(): bool
+    {
+        $locale = app()->getLocale();
+
+        return null !== $this->cachedTranslationModels->firstWhere('locale', $locale);
+    }
+
+    /**
+     * Fetches and caches the translation models for the given locale.
+     *
+     * @param string $locale the locale to fetch translations for
+     *
+     * @return Collection the collection of translation models
+     */
+    private function fetchAndCacheTranslations(string $locale): Collection
+    {
+        return $this->translation()->locale($locale)->get();
     }
 }

tests/TranslationModelTest.php

@@ -101,6 +101,32 @@ public function testItTranslatesOnlyTranslatableAttributes()
         $this->assertEquals('some text goes here', $post->body);
     }
 
+    public function testItTranslatesAttributesImmediatelyAfterSwitchingLocale()
+    {
+        $post       = new Post();
+        $post->id   = 1;
+        $post->name = 'original text goes here';
+
+        $post->translation()->saveMany([
+            new Translation([
+                'locale' => 'fr_FR',
+                'key'    => 'name',
+                'value'  => 'un texte va ici',
+            ]),
+            new Translation([
+                'locale' => 'es_ES',
+                'key'    => 'name',
+                'value'  => 'aqui va un texto',
+            ]),
+        ]);
+
+        app()->setLocale('fr_FR');
+        $this->assertEquals('un texte va ici', $post->name);
+
+        app()->setLocale('es_ES');
+        $this->assertEquals('aqui va un texto', $post->name);
+    }
+
     public function testItTranslatesAllAttributesIfNoTranslatableAttributesAreDefined()
     {
         $post = new class() extends Post {