From a6b2cc7be34f0ce7583dad5e80d203d4048c2de0 Mon Sep 17 00:00:00 2001 From: souhailaS Date: Tue, 15 Jul 2025 14:36:12 +0200 Subject: [PATCH 1/2] Deduplicate static checks in CI workflow Combine typecheck, lint, and yarn-validate jobs into a single static-checks job to eliminate duplication of setup steps and dependencies. --- .github/workflows/nodejs.yml | 41 +++++------------------------------- 1 file changed, 5 insertions(+), 36 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index cfefe6701472..969a7d835ea9 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -56,8 +56,8 @@ jobs: - name: Run tests depending on type information run: yarn test-with-type-info - typecheck: - name: Typecheck Examples and Tests + static-checks: + name: Static Checks (Lint, Typecheck, Yarn Validate) runs-on: ubuntu-latest needs: prepare-yarn-cache-ubuntu @@ -71,30 +71,14 @@ jobs: cache: yarn - name: install run: yarn --immutable - - name: build + - name: build TypeScript run: yarn build:ts + - name: build JavaScript + run: yarn build:js - name: typecheck examples run: yarn typecheck:examples - name: typecheck tests run: yarn typecheck:tests - - lint: - name: Lint - runs-on: ubuntu-latest - needs: prepare-yarn-cache-ubuntu - - steps: - - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 - with: - persist-credentials: false - - uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0 - with: - node-version: lts/* - cache: yarn - - name: install - run: yarn --immutable - - name: build - run: yarn build:js - name: verify Yarn PnP compatibility run: yarn verify-pnp - name: run eslint @@ -105,21 +89,6 @@ jobs: run: yarn check-changelog - name: check copyright headers run: yarn check-copyright-headers - - yarn-validate: - name: Validate Yarn dependencies and constraints - runs-on: ubuntu-latest - needs: prepare-yarn-cache-ubuntu - steps: - - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 - with: - persist-credentials: false - - uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0 - with: - node-version: lts/* - cache: yarn - - name: install - run: yarn --immutable - name: 'Check for unmet constraints (fix w/ "yarn constraints --fix")' run: yarn constraints - name: 'Check for duplicate dependencies (fix w/ "yarn dedupe")' From b18b37797db8848353ab7005eb522a7f449f92cd Mon Sep 17 00:00:00 2001 From: souhailaS Date: Tue, 15 Jul 2025 14:37:43 +0200 Subject: [PATCH 2/2] Update CHANGELOG.md for CI workflow deduplication --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 31652ea233da..84ec7ed5d1bf 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,7 @@ ### Fixes - `[expect]` Fix `bigint` error ([#15702](https://github.com/jestjs/jest/pull/15702)) +- `[ci]` Deduplicate static checks in CI workflow by combining typecheck, lint, and yarn-validate jobs ## 30.0.4