Skip to content

Conversation

@cpojer
Copy link
Member

@cpojer cpojer commented Jun 5, 2025

Summary

I'm working on removing webpack, TypeScript and Babel from our build pipeline in favor of tsdown and rolldown. We are relying on some Babel plugins that we no longer really need, so I'm going to remove them.

As a very late follow-up to @jeysal's PR #10824, this removes the Babel plugin that was added many years ago. We only have 4 occurrences of requireOutside, and I think it's ok to inline those.

Test plan

yolo

@cpojer cpojer requested a review from SimenB June 5, 2025 14:25
@netlify
Copy link

netlify bot commented Jun 5, 2025

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit be5492e
🔍 Latest deploy log https://app.netlify.com/projects/jestjs/deploys/6841a8ced69aa50008bf174a
😎 Deploy Preview https://deploy-preview-15658--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 5, 2025

Open in StackBlitz

babel-jest

npm i https://pkg.pr.new/babel-jest@15658

babel-plugin-jest-hoist

npm i https://pkg.pr.new/babel-plugin-jest-hoist@15658

babel-preset-jest

npm i https://pkg.pr.new/babel-preset-jest@15658

create-jest

npm i https://pkg.pr.new/create-jest@15658

@jest/diff-sequences

npm i https://pkg.pr.new/@jest/diff-sequences@15658

expect

npm i https://pkg.pr.new/expect@15658

@jest/expect-utils

npm i https://pkg.pr.new/@jest/expect-utils@15658

jest

npm i https://pkg.pr.new/jest@15658

jest-changed-files

npm i https://pkg.pr.new/jest-changed-files@15658

jest-circus

npm i https://pkg.pr.new/jest-circus@15658

jest-cli

npm i https://pkg.pr.new/jest-cli@15658

jest-config

npm i https://pkg.pr.new/jest-config@15658

@jest/console

npm i https://pkg.pr.new/@jest/console@15658

@jest/core

npm i https://pkg.pr.new/@jest/core@15658

@jest/create-cache-key-function

npm i https://pkg.pr.new/@jest/create-cache-key-function@15658

jest-diff

npm i https://pkg.pr.new/jest-diff@15658

jest-docblock

npm i https://pkg.pr.new/jest-docblock@15658

jest-each

npm i https://pkg.pr.new/jest-each@15658

@jest/environment

npm i https://pkg.pr.new/@jest/environment@15658

jest-environment-jsdom

npm i https://pkg.pr.new/jest-environment-jsdom@15658

@jest/environment-jsdom-abstract

npm i https://pkg.pr.new/@jest/environment-jsdom-abstract@15658

jest-environment-node

npm i https://pkg.pr.new/jest-environment-node@15658

@jest/expect

npm i https://pkg.pr.new/@jest/expect@15658

@jest/fake-timers

npm i https://pkg.pr.new/@jest/fake-timers@15658

@jest/get-type

npm i https://pkg.pr.new/@jest/get-type@15658

@jest/globals

npm i https://pkg.pr.new/@jest/globals@15658

jest-haste-map

npm i https://pkg.pr.new/jest-haste-map@15658

jest-jasmine2

npm i https://pkg.pr.new/jest-jasmine2@15658

jest-leak-detector

npm i https://pkg.pr.new/jest-leak-detector@15658

jest-matcher-utils

npm i https://pkg.pr.new/jest-matcher-utils@15658

jest-message-util

npm i https://pkg.pr.new/jest-message-util@15658

jest-mock

npm i https://pkg.pr.new/jest-mock@15658

@jest/pattern

npm i https://pkg.pr.new/@jest/pattern@15658

jest-phabricator

npm i https://pkg.pr.new/jest-phabricator@15658

jest-regex-util

npm i https://pkg.pr.new/jest-regex-util@15658

jest-repl

npm i https://pkg.pr.new/jest-repl@15658

@jest/reporters

npm i https://pkg.pr.new/@jest/reporters@15658

jest-resolve

npm i https://pkg.pr.new/jest-resolve@15658

jest-resolve-dependencies

npm i https://pkg.pr.new/jest-resolve-dependencies@15658

jest-runner

npm i https://pkg.pr.new/jest-runner@15658

jest-runtime

npm i https://pkg.pr.new/jest-runtime@15658

@jest/schemas

npm i https://pkg.pr.new/@jest/schemas@15658

jest-snapshot

npm i https://pkg.pr.new/jest-snapshot@15658

@jest/snapshot-utils

npm i https://pkg.pr.new/@jest/snapshot-utils@15658

@jest/source-map

npm i https://pkg.pr.new/@jest/source-map@15658

@jest/test-result

npm i https://pkg.pr.new/@jest/test-result@15658

@jest/test-sequencer

npm i https://pkg.pr.new/@jest/test-sequencer@15658

@jest/transform

npm i https://pkg.pr.new/@jest/transform@15658

@jest/types

npm i https://pkg.pr.new/@jest/types@15658

jest-util

npm i https://pkg.pr.new/jest-util@15658

jest-validate

npm i https://pkg.pr.new/jest-validate@15658

jest-watcher

npm i https://pkg.pr.new/jest-watcher@15658

jest-worker

npm i https://pkg.pr.new/jest-worker@15658

pretty-format

npm i https://pkg.pr.new/pretty-format@15658

commit: be5492e

Copy link
Collaborator

@jeysal jeysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, for the amount of usages we ended up with it's probably not worth having it

@cpojer cpojer merged commit 109069b into jestjs:main Jun 5, 2025
76 checks passed
@cpojer
Copy link
Member Author

cpojer commented Jun 5, 2025

If we need it more often in the future, we can also build a runtime helper for it.

@github-actions
Copy link

github-actions bot commented Jul 6, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants