Skip to content

Conversation

@JounQin
Copy link
Collaborator

@JounQin JounQin commented Jun 5, 2025

Summary

related #15556 (comment)

http://github.com/apps/pkg-pr-new needs to be installed first.

cc @cpojer

Test plan

@netlify
Copy link

netlify bot commented Jun 5, 2025

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9f4f618
🔍 Latest deploy log https://app.netlify.com/projects/jestjs/deploys/68414171f9be880008e1ff43
😎 Deploy Preview https://deploy-preview-15655--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@cpojer
Copy link
Member

cpojer commented Jun 5, 2025

App installed for the Jest repo.

What's with the lockfile changes?

@JounQin
Copy link
Collaborator Author

JounQin commented Jun 5, 2025

What's with the lockfile changes?

#15654. I was going to update the lockfile, but it's merged too fast. 😂

@cpojer
Copy link
Member

cpojer commented Jun 5, 2025

Ok, how do we test that pkg-pr is working?

@JounQin
Copy link
Collaborator Author

JounQin commented Jun 5, 2025

Ok, how do we test that pkg-pr is working?

https://github.com/jestjs/jest/actions/runs/15460659252/job/43521124693?pr=15655#step:6:35

It seems it's required to be merged first? 😂

Although I didn't meet this error previously, or can you just rerun it?

@cpojer
Copy link
Member

cpojer commented Jun 5, 2025

I'll try rerunning the action now that the app is enabled.

@JounQin
Copy link
Collaborator Author

JounQin commented Jun 5, 2025

@cpojer
Copy link
Member

cpojer commented Jun 5, 2025

Sweet! How do we quickly find the version number associated with a PR so people can install it?

@cpojer cpojer merged commit af3b842 into jestjs:main Jun 5, 2025
76 of 77 checks passed
@JounQin JounQin deleted the ci/pkg-pr-new branch June 5, 2025 07:25
@JounQin
Copy link
Collaborator Author

JounQin commented Jun 5, 2025

How do we quickly find the version number associated with a PR so people can install it?

I believe after this PR merged, it'll just work to comment automatically like

un-ts/synckit#250 (comment)

@cpojer
Copy link
Member

cpojer commented Jun 5, 2025

Sweet, thank you, this is gonna be really useful. I appreciate all your contributions to Jest 🙇‍♂️

@JounQin
Copy link
Collaborator Author

JounQin commented Jun 5, 2025

May I ask for joining the team by the way?

@github-actions
Copy link

github-actions bot commented Jul 6, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants