in commits, if `yu` (aka Copy URL of commit) it always assumes the remote is named `origin`

[Arniiiii]

Describe the bug
A clear and concise description of what the bug is.
in commits, if yu (aka Copy URL of commit) it always assumes the remote is origin

To Reproduce
Steps to reproduce the behavior:

1. Make sure you are on branch that has upstream remote not on remote named origin
2. Go to 'Commits'
3. Press yu on a commit
4. See error and confirmation of the problem in Command log

Expected behavior
A clear and concise description of what you expected to happen.

Use branch's remote's name/URL .

Screenshots
If applicable, add screenshots to help explain your problem.

Version info:
Run lazygit --version and paste the result here

commit=, build date=, build source=unknown, version=0.45.2, os=linux, arch=amd64, git version=2.49.0

Run git --version and paste the result here

git version 2.49.0

OS: Gentoo Linux

UPD: I can confirm that lazygit-0.52.0 fails in the same way

UPD: I can confirm that lazygit-0.53.0 fails in the same way

Additional context
Add any other context about the problem here.

Note: please try updating to the latest version or manually building the latest master to see if the issue still occurs.

I'll check little bit later if last version has the problem

[RBird111]

The fix for this is simple enough, drop the parameter in GetRemoteURL and modify the single place its called in getHostingServiceMgr.
This would grab the correct URL for repositories where the remote name != origin:

git-test on  main
λ ❯ git ls-remote --get-url origin
origin

git-test on  main
λ ❯ git ls-remote --get-url
https://github.com/RBird111/git-test.git

while the output for repositories where the remote name == origin would remain unchanged:

lazygit on  master [!] via  v1.24.5
λ ❯ git ls-remote --get-url origin
https://github.com/jesseduffield/lazygit.git

lazygit on  master [!] via  v1.24.5
λ ❯ git ls-remote --get-url
https://github.com/jesseduffield/lazygit.git

However, both repos I used for tested are hosted on github so I'm not sure if the behavior would change for other platforms.

@stefanhaller - Right now getHostingServiceMgr passes in a hardcoded value of "origin" to GetRemoteURL, is this to guard against any edge cases? If not, I'd be happy to submit a PR for this issue.

[stefanhaller]

@RBird111 I wasn't involved in the development of the hosting services code (except for b470442, which doesn't change that we hard-code "origin"), so I don't know more about it than you. 😄 Also, I don't have access to any other hosting services besides github, so I wouldn't be able to do any testing on those.

But what you suggest sounds reasonable to me. My only concern is where you would get the remote from: the selected commit could either be a local commit, in which case we would be looking at the currently checked out branch, but it could also be the subcommits of either a local branch or a remote branch, and I'm not sure there's an easy way to tell. I haven't investigated this, let me know if you need assistance figuring this out.