Keybinds: Search by keybind

[goyalyashpal]

Is your feature request related to a problem? Please describe.
unable to refresh my mind quickly on exact description of what the keybinds i use do.

this request is low priority from my side. and made only under the premise that it will be trivial in complexity / technical debt to implement.

Describe the solution you'd like
/ filter in keybinds should allow querying keybind too
maybe by prefixing them with say colon :, it should switch to filter keybinds.

Describe alternatives you've considered

Additional context
Add any other context or screenshots about the feature request here.

• various other software allow searching both by actions and keybinds
• vscodium comes to mind as an example

$ lazygit --version  | cut --fields=3-7 --delimiter=',' --output-delimiter=$'\n'  | column --table --separator '='
 build source  nix
 version       0.52.0
 os            linux
 arch          amd64
 git version   2.49.0

[stefanhaller]

I have missed this myself a few times, but unfortunately this is not really trivial to do.

A naïve implementation would be this

diff --git a/pkg/gui/context/menu_context.go b/pkg/gui/context/menu_context.go
index 3d5937a9d..73e894d90 100644
--- a/pkg/gui/context/menu_context.go
+++ b/pkg/gui/context/menu_context.go
@@ -64,7 +64,9 @@ func NewMenuViewModel(c *ContextCommon) *MenuViewModel {
 
 	self.FilteredListViewModel = NewFilteredListViewModel(
 		func() []*types.MenuItem { return self.menuItems },
-		func(item *types.MenuItem) []string { return item.LabelColumns },
+		func(item *types.MenuItem) []string {
+			return append(item.LabelColumns, keybindings.LabelFromKey(item.Key))
+		},
 	)
 
 	return self

which simply includes the keybinding in the data that the list is filtered by. This is ok if you search for things like enter or c-f, but it doesn't work well if you are looking for the command that is bound to e.

I like the idea of prefixing the filter with : to search for keybindings, although that wouldn't be very discoverable, so we would have to try to include a hint to this in the filter prompt somehow.

(Also, this applies to all menus, not just the keybindings menu, but that's probably not an issue in practice. I doubt there are many other menus that users want to filter, except maybe the recent repos menu, which doesn't have keybindings.)