Select hunk (a) broken

[xuyangyuio]

In the "Unstaged changes" pane, press a to select hunk, but the hunk is not correctly selected.

[ChrisMcD1]

Can you give some more details about what steps you are taking to produce this? Particularly if you have configured a non-default pager.

Here is me prior to pressing a:

and after pressing a

which is expected behavior. I can then click <space> to confirm that I want to stage that hunk.

[xuyangyuio]

I use delta, in my config: pager: delta --paging=never --line-numbers --hyperlinks --hyperlinks-file-link-format="lazygit-edit://{path}:{line}"

The hunk is selected, but partial like:

[stefanhaller]

I've seen this too. I think it happens for longer hunks, where the view needs to scroll so that the end of the hunk becomes visible. As far as I remember, this is only a visual problem, pressing space to stage the hunk should still work fine (not 100% sure on that).

I'll have a closer look when I find some time.

[wiraki]

I can confirm I see the same behavior. Indeed it seems to only be a visual bug for longer hunks, but staging still works fine. However, it is sometimes difficult to understand what will be considered as a hunk and what not due to this.

I imagine this has nothing to do with the custom pager since it is currently not used in the staging mode, but just in case, I am also using delta as the custom pager.

[santhosh-tekuri]

this is happening for me. I have delta configured for git. but not for lazygit

[adriangalilea]

I can confirm this bug happens even with NO configuration at all. Tested on macOS with lazygit v0.45.2.

Test setup:

• Removed lazygit config entirely (no ~/.config/lazygit/config.yml)
• Disabled git pager (git config --global core.pager "")
• Disabled interactive.diffFilter

Results:

• numbers.txt with non-contiguous changes: 'a' selects entire file instead of hunk

All gets staged upon pressing space

• app.js with long functions: Visual selection highlight glitch

But all gets staged upon pressing space

• test_hunk.py Visual selection highlight glitch,

But this time stages fine.

So this is definitely a core lazygit bug, not related to delta or any user configuration. The bug manifests differently depending on the file content and hunk structure.

[stefanhaller]

Thanks for the elaborate report Adrian, but we have a fix for this already (#4589), it just hasn't been merged yet. Please test it if you can build from source.

And btw, 0.45 is really old, do yourself a favor and update to the latest version. You are missing out on a ton of new enhancements and fixes.

[adriangalilea]

And btw, 0.45 is really old, do yourself a favor and update to the latest version. You are missing out on a ton of new enhancements and fixes.

Oh, I wasn't aware! Thanks for letting me know.

it just hasn't been merged yet

ETA?