Cleanup: remove pointless error handling

stefanhaller · stefanhaller · commit ee62878e6b26 · 2025-07-02T15:47:48.000+02:00
ForEachFile can't possibly return an error if the passed function doesn't return
one.
diff --git a/pkg/gui/controllers/commits_files_controller.go b/pkg/gui/controllers/commits_files_controller.go
@@ -319,13 +319,10 @@ func (self *CommitFilesController) discard(selectedNodes []*filetree.CommitFileN
 				}
 
 				for _, node := range selectedNodes {
-					err := node.ForEachFile(func(file *models.CommitFile) error {
+					_ = node.ForEachFile(func(file *models.CommitFile) error {
 						filePaths = append(filePaths, file.GetPath())
 						return nil
 					})
-					if err != nil {
-						return err
-					}
 				}
 
 				err := self.c.Git().Rebase.DiscardOldFileChanges(self.c.Model().Commits, self.c.Contexts().LocalCommits.GetSelectedLineIdx(), filePaths)

Original file line number	Diff line number	Diff line change
`@@ -319,13 +319,10 @@ func (self CommitFilesController) discard(selectedNodes []filetree.CommitFileN`
`319`	`319`	`}`
`320`	`320`
`321`	`321`	`for _, node := range selectedNodes {`
`322`		`- err := node.ForEachFile(func(file *models.CommitFile) error {`
	`322`	`+ _ = node.ForEachFile(func(file *models.CommitFile) error {`
`323`	`323`	`filePaths = append(filePaths, file.GetPath())`
`324`	`324`	`return nil`
`325`	`325`	`})`
`326`		`- if err != nil {`
`327`		`- return err`
`328`		`- }`
`329`	`326`	`}`
`330`	`327`
`331`	`328`	`err := self.c.Git().Rebase.DiscardOldFileChanges(self.c.Model().Commits, self.c.Contexts().LocalCommits.GetSelectedLineIdx(), filePaths)`