Skip to content

Commit cd36e95

Browse files
committed
Rename RebaseMode to WorkingTreeState
We're about to add more possible values (reverting and cherry-picking), so working tree state seems like a more suitable name.
1 parent 1a73697 commit cd36e95

17 files changed

+50
-50
lines changed

pkg/commands/git_commands/commit_loader.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ type CommitLoader struct {
3131
*common.Common
3232
cmd oscommands.ICmdObjBuilder
3333

34-
getWorkingTreeState func() enums.RebaseMode
34+
getWorkingTreeState func() enums.WorkingTreeState
3535
readFile func(filename string) ([]byte, error)
3636
walkFiles func(root string, fn filepath.WalkFunc) error
3737
dotGitDir string
@@ -42,7 +42,7 @@ type CommitLoader struct {
4242
func NewCommitLoader(
4343
cmn *common.Common,
4444
cmd oscommands.ICmdObjBuilder,
45-
getWorkingTreeState func() enums.RebaseMode,
45+
getWorkingTreeState func() enums.WorkingTreeState,
4646
gitCommon *GitCommon,
4747
) *CommitLoader {
4848
return &CommitLoader{

pkg/commands/git_commands/commit_loader_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -304,7 +304,7 @@ func TestGetCommits(t *testing.T) {
304304
builder := &CommitLoader{
305305
Common: common,
306306
cmd: cmd,
307-
getWorkingTreeState: func() enums.RebaseMode { return enums.REBASE_MODE_NONE },
307+
getWorkingTreeState: func() enums.WorkingTreeState { return enums.WORKING_TREE_STATE_NONE },
308308
dotGitDir: ".git",
309309
readFile: func(filename string) ([]byte, error) {
310310
return []byte(""), nil
@@ -487,7 +487,7 @@ func TestCommitLoader_getConflictedCommitImpl(t *testing.T) {
487487
builder := &CommitLoader{
488488
Common: common,
489489
cmd: oscommands.NewDummyCmdObjBuilder(oscommands.NewFakeRunner(t)),
490-
getWorkingTreeState: func() enums.RebaseMode { return enums.REBASE_MODE_REBASING },
490+
getWorkingTreeState: func() enums.WorkingTreeState { return enums.WORKING_TREE_STATE_REBASING },
491491
dotGitDir: ".git",
492492
readFile: func(filename string) ([]byte, error) {
493493
return []byte(""), nil

pkg/commands/git_commands/patch.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ func (self *PatchCommands) MovePatchIntoIndex(commits []*models.Commit, commitId
229229
}
230230

231231
if err := self.ApplyCustomPatch(true, true); err != nil {
232-
if self.status.WorkingTreeState() == enums.REBASE_MODE_REBASING {
232+
if self.status.WorkingTreeState() == enums.WORKING_TREE_STATE_REBASING {
233233
_ = self.rebase.AbortRebase()
234234
}
235235
return err
@@ -253,7 +253,7 @@ func (self *PatchCommands) MovePatchIntoIndex(commits []*models.Commit, commitId
253253
self.rebase.onSuccessfulContinue = func() error {
254254
// add patches to index
255255
if err := self.ApplyPatch(patch, ApplyPatchOpts{Index: true, ThreeWay: true}); err != nil {
256-
if self.status.WorkingTreeState() == enums.REBASE_MODE_REBASING {
256+
if self.status.WorkingTreeState() == enums.WORKING_TREE_STATE_REBASING {
257257
_ = self.rebase.AbortRebase()
258258
}
259259
return err

pkg/commands/git_commands/status.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,16 +20,16 @@ func NewStatusCommands(
2020
}
2121
}
2222

23-
func (self *StatusCommands) WorkingTreeState() enums.RebaseMode {
23+
func (self *StatusCommands) WorkingTreeState() enums.WorkingTreeState {
2424
isInRebase, _ := self.IsInRebase()
2525
if isInRebase {
26-
return enums.REBASE_MODE_REBASING
26+
return enums.WORKING_TREE_STATE_REBASING
2727
}
2828
merging, _ := self.IsInMergeState()
2929
if merging {
30-
return enums.REBASE_MODE_MERGING
30+
return enums.WORKING_TREE_STATE_MERGING
3131
}
32-
return enums.REBASE_MODE_NONE
32+
return enums.WORKING_TREE_STATE_NONE
3333
}
3434

3535
func (self *StatusCommands) IsBareRepo() bool {

pkg/commands/types/enums/enums.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
package enums
22

3-
type RebaseMode int
3+
type WorkingTreeState int
44

55
const (
66
// this means we're neither rebasing nor merging
7-
REBASE_MODE_NONE RebaseMode = iota
8-
REBASE_MODE_REBASING
9-
REBASE_MODE_MERGING
7+
WORKING_TREE_STATE_NONE WorkingTreeState = iota
8+
WORKING_TREE_STATE_REBASING
9+
WORKING_TREE_STATE_MERGING
1010
)
1111

12-
func (self RebaseMode) IsMerging() bool {
13-
return self == REBASE_MODE_MERGING
12+
func (self WorkingTreeState) IsMerging() bool {
13+
return self == WORKING_TREE_STATE_MERGING
1414
}
1515

16-
func (self RebaseMode) IsRebasing() bool {
17-
return self == REBASE_MODE_REBASING
16+
func (self WorkingTreeState) IsRebasing() bool {
17+
return self == WORKING_TREE_STATE_REBASING
1818
}

pkg/gui/context/local_commits_context.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ func NewLocalCommitsContext(c *ContextCommon) *LocalCommitsContext {
4141
}
4242
}
4343

44-
showYouAreHereLabel := c.Model().WorkingTreeStateAtLastCommitRefresh == enums.REBASE_MODE_REBASING
44+
showYouAreHereLabel := c.Model().WorkingTreeStateAtLastCommitRefresh == enums.WORKING_TREE_STATE_REBASING
4545
hasRebaseUpdateRefsConfig := c.Git().Config.GetRebaseUpdateRefs()
4646

4747
return presentation.GetCommitListDisplayStrings(

pkg/gui/controllers/custom_patch_options_menu_action.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ func (self *CustomPatchOptionsMenuAction) Call() error {
4444
},
4545
}
4646

47-
if self.c.Git().Patch.PatchBuilder.CanRebase && self.c.Git().Status.WorkingTreeState() == enums.REBASE_MODE_NONE {
47+
if self.c.Git().Patch.PatchBuilder.CanRebase && self.c.Git().Status.WorkingTreeState() == enums.WORKING_TREE_STATE_NONE {
4848
menuItems = append(menuItems, []*types.MenuItem{
4949
{
5050
Label: fmt.Sprintf(self.c.Tr.RemovePatchFromOriginalCommit, self.c.Git().Patch.PatchBuilder.To),
@@ -115,7 +115,7 @@ func (self *CustomPatchOptionsMenuAction) getPatchCommitIndex() int {
115115
}
116116

117117
func (self *CustomPatchOptionsMenuAction) validateNormalWorkingTreeState() (bool, error) {
118-
if self.c.Git().Status.WorkingTreeState() != enums.REBASE_MODE_NONE {
118+
if self.c.Git().Status.WorkingTreeState() != enums.WORKING_TREE_STATE_NONE {
119119
return false, errors.New(self.c.Tr.CantPatchWhileRebasingError)
120120
}
121121
return true, nil

pkg/gui/controllers/helpers/merge_and_rebase_helper.go

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ func (self *MergeAndRebaseHelper) CreateRebaseOptionsMenu() error {
5151
{option: REBASE_OPTION_ABORT, key: 'a'},
5252
}
5353

54-
if self.c.Git().Status.WorkingTreeState() == enums.REBASE_MODE_REBASING {
54+
if self.c.Git().Status.WorkingTreeState() == enums.WORKING_TREE_STATE_REBASING {
5555
options = append(options, optionAndKey{
5656
option: REBASE_OPTION_SKIP, key: 's',
5757
})
@@ -68,7 +68,7 @@ func (self *MergeAndRebaseHelper) CreateRebaseOptionsMenu() error {
6868
})
6969

7070
var title string
71-
if self.c.Git().Status.WorkingTreeState() == enums.REBASE_MODE_MERGING {
71+
if self.c.Git().Status.WorkingTreeState() == enums.WORKING_TREE_STATE_MERGING {
7272
title = self.c.Tr.MergeOptionsTitle
7373
} else {
7474
title = self.c.Tr.RebaseOptionsTitle
@@ -84,12 +84,12 @@ func (self *MergeAndRebaseHelper) ContinueRebase() error {
8484
func (self *MergeAndRebaseHelper) genericMergeCommand(command string) error {
8585
status := self.c.Git().Status.WorkingTreeState()
8686

87-
if status != enums.REBASE_MODE_MERGING && status != enums.REBASE_MODE_REBASING {
87+
if status != enums.WORKING_TREE_STATE_MERGING && status != enums.WORKING_TREE_STATE_REBASING {
8888
return errors.New(self.c.Tr.NotMergingOrRebasing)
8989
}
9090

9191
self.c.LogAction(fmt.Sprintf("Merge/Rebase: %s", command))
92-
if status == enums.REBASE_MODE_REBASING {
92+
if status == enums.WORKING_TREE_STATE_REBASING {
9393
todoFile, err := os.ReadFile(
9494
filepath.Join(self.c.Git().RepoPaths.WorktreeGitDirPath(), "rebase-merge/git-rebase-todo"),
9595
)
@@ -105,9 +105,9 @@ func (self *MergeAndRebaseHelper) genericMergeCommand(command string) error {
105105

106106
commandType := ""
107107
switch status {
108-
case enums.REBASE_MODE_MERGING:
108+
case enums.WORKING_TREE_STATE_MERGING:
109109
commandType = "merge"
110-
case enums.REBASE_MODE_REBASING:
110+
case enums.WORKING_TREE_STATE_REBASING:
111111
commandType = "rebase"
112112
default:
113113
// shouldn't be possible to land here
@@ -116,10 +116,10 @@ func (self *MergeAndRebaseHelper) genericMergeCommand(command string) error {
116116
// we should end up with a command like 'git merge --continue'
117117

118118
// it's impossible for a rebase to require a commit so we'll use a subprocess only if it's a merge
119-
needsSubprocess := (status == enums.REBASE_MODE_MERGING && command != REBASE_OPTION_ABORT && self.c.UserConfig().Git.Merging.ManualCommit) ||
119+
needsSubprocess := (status == enums.WORKING_TREE_STATE_MERGING && command != REBASE_OPTION_ABORT && self.c.UserConfig().Git.Merging.ManualCommit) ||
120120
// but we'll also use a subprocess if we have exec todos; those are likely to be lengthy build
121121
// tasks whose output the user will want to see in the terminal
122-
(status == enums.REBASE_MODE_REBASING && command != REBASE_OPTION_ABORT && self.hasExecTodos())
122+
(status == enums.WORKING_TREE_STATE_REBASING && command != REBASE_OPTION_ABORT && self.hasExecTodos())
123123

124124
if needsSubprocess {
125125
// TODO: see if we should be calling more of the code from self.Git.Rebase.GenericMergeOrRebaseAction
@@ -239,9 +239,9 @@ func (self *MergeAndRebaseHelper) AbortMergeOrRebaseWithConfirm() error {
239239
func (self *MergeAndRebaseHelper) workingTreeStateNoun() string {
240240
workingTreeState := self.c.Git().Status.WorkingTreeState()
241241
switch workingTreeState {
242-
case enums.REBASE_MODE_NONE:
242+
case enums.WORKING_TREE_STATE_NONE:
243243
return ""
244-
case enums.REBASE_MODE_MERGING:
244+
case enums.WORKING_TREE_STATE_MERGING:
245245
return "merge"
246246
default:
247247
return "rebase"

pkg/gui/controllers/helpers/mode_helper.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ func (self *ModeHelper) Statuses() []ModeStatus {
116116
},
117117
{
118118
IsActive: func() bool {
119-
return !self.suppressRebasingMode && self.c.Git().Status.WorkingTreeState() != enums.REBASE_MODE_NONE
119+
return !self.suppressRebasingMode && self.c.Git().Status.WorkingTreeState() != enums.WORKING_TREE_STATE_NONE
120120
},
121121
Description: func() string {
122122
workingTreeState := self.c.Git().Status.WorkingTreeState()

pkg/gui/controllers/helpers/patch_building_helper.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ func NewPatchBuildingHelper(
2222
}
2323

2424
func (self *PatchBuildingHelper) ValidateNormalWorkingTreeState() (bool, error) {
25-
if self.c.Git().Status.WorkingTreeState() != enums.REBASE_MODE_NONE {
25+
if self.c.Git().Status.WorkingTreeState() != enums.WORKING_TREE_STATE_NONE {
2626
return false, errors.New(self.c.Tr.CantPatchWhileRebasingError)
2727
}
2828
return true, nil

0 commit comments

Comments
 (0)