Skip to content

Commit 6fb3b74

Browse files
Chris McDonnellstefanhaller
authored andcommitted
refactor: Make commit.gpgSign match official capitalization
The actual usage is case insensitive, so this doesn't actually matter. But if fills my heart with joy. The test is case sensitive, but the actual response to `git config commit.gpgSign` is equivalent to `git config commit.gppsign`
1 parent 52da806 commit 6fb3b74

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

pkg/commands/git_commands/config.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ func (self *ConfigCommands) NeedsGpgSubprocessForCommit() bool {
6666
return false
6767
}
6868

69-
return self.gitConfig.GetBool("commit.gpgsign")
69+
return self.gitConfig.GetBool("commit.gpgSign")
7070
}
7171

7272
func (self *ConfigCommands) GetCoreEditor() string {

pkg/commands/git_commands/rebase_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ func TestRebaseDiscardOldFileChanges(t *testing.T) {
128128
},
129129
{
130130
testName: "returns error when using gpg",
131-
gitConfigMockResponses: map[string]string{"commit.gpgsign": "true"},
131+
gitConfigMockResponses: map[string]string{"commit.gpgSign": "true"},
132132
commits: []*models.Commit{{Name: "commit", Hash: "123456"}},
133133
commitIndex: 0,
134134
fileName: []string{"test999.txt"},

0 commit comments

Comments
 (0)