Skip to content

Some cleaning is necessary #53

@zspecza

Description

@zspecza

Over time, Rupture has evolved into something I didn't quite expect, and I think this is amazing. However, I think maintainability has been neglected a little too much in favour of feature additions. Rupture needs a better codebase, and in order to achieve that, the following is needed:

  • Comments. There is only one comment block in the entire file at the moment
  • The really long parameter lists need to be separated on to multiple lines
  • Aliases need to be grouped in one place
  • Trying to avoid going over 80 characters in line length where possible
  • Rogue partial code blocks - some of the code that is only needed at the bottom of a mixin is at the top and needs to be moved in order to make sense
  • There are a few repeated blocks of code that can be turned into utility functions
  • Assume no-conflict by defining mixins as rupture-[keyword], but alias as [keyword]. Give an option to turn off the aliasing. This future-proofs us from issues like the one with those blasted gradients _shakes fist_.
  • A few refactors here and there.

I have already begun working on this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions