Use foreach for looping variables

jeroendesloovere · jeroendesloovere · commit 08027e3900ff · 2018-04-03T09:33:26.000+02:00
diff --git a/src/Geolocation.php b/src/Geolocation.php
@@ -170,12 +170,12 @@ public function getCoordinates(
     ): Coordinates {
         $items = [];
         $variables = [$street, $streetNumber, $city, $zip, $country];
-        for ($i = 0; $i < count($variables); $i ++) {
-            if (empty($variables[$i])) {
+        foreach ($variables as $variable) {
+            if (empty($variable)) {
                 continue;
             }
 
-            $items[] = $variables[$i];
+            $items[] = $variable;
         }
 
         $results = $this->doCall(array(

Original file line number	Diff line number	Diff line change
`@@ -170,12 +170,12 @@ public function getCoordinates(`
`170`	`170`	`): Coordinates {`
`171`	`171`	`$items = [];`
`172`	`172`	`$variables = [$street, $streetNumber, $city, $zip, $country];`
`173`		`- for ($i = 0; $i < count($variables); $i ++) {`
`174`		`- if (empty($variables[$i])) {`
	`173`	`+ foreach ($variables as $variable) {`
	`174`	`+ if (empty($variable)) {`
`175`	`175`	`continue;`
`176`	`176`	`}`
`177`	`177`
`178`		`- $items[] = $variables[$i];`
	`178`	`+ $items[] = $variable;`
`179`	`179`	`}`
`180`	`180`
`181`	`181`	`$results = $this->doCall(array(`