Combine nested_attributes and class_table_inheritance?

[rolftimmermans]

I think it would be nice to allow nested_attributes in combination with class_table_inheritance. Currently these two plugins don't work together.

It seems that changing this line should work?

sequel/lib/sequel/plugins/nested_attributes.rb

Line 194 in 767133e

obj = reflection.associated_class.new

Replacing:

obj = reflection.associated_class.new

with:

model = reflection.associated_class
obj = if model.respond_to?(:cti_models) && (kind = attributes[model.sti_key])
  model.sti_class_from_sti_key(attributes.delete(model.sti_key)).new
else
  model.new
end

What do you think? Is this something worth supporting?

[jeremyevans]

I try to avoid such optional dependencies between plugins, though I'm not always successful. One way to avoid such an optional dependency in this case is to extract the reflection.associated_class.new into a method, and then you can override that method to get the behavior you want.

[rolftimmermans]

Right, in this case the behaviour is dependent on the attributes though, so then reflection.associated_class.new would need to be moved into a method like:

def instantiate_model(reflection, attributes)
  reflection.associated_class.new
end

And the referenced line would become:

obj = instantiate_model(reflection, attributes)

Is that what you mean?

[jeremyevans]

Yes, something like that.

[rolftimmermans]

Thank you; I've opened a PR here: #2283