Replace is_trivial, resolves #236

Author: jeremy-rifkin

src/utils/io/base_file.hpp

@@ -14,7 +14,13 @@ namespace detail {
         virtual string_view path() const = 0;
         virtual Result<monostate, internal_error> read_bytes(bspan buffer, off_t offset) const = 0;
 
-        template<typename T, typename std::enable_if<std::is_trivial<T>::value && !is_span<T>::value, int>::type = 0>
+        template<
+            typename T,
+            typename std::enable_if<
+                std::is_standard_layout<T>::value && std::is_trivially_copyable<T>::value && !is_span<T>::value,
+                int
+            >::type = 0
+        >
         Result<T, internal_error> read(off_t offset) {
             T object{};
             auto res = read_bytes(make_bspan(object), offset);
@@ -24,7 +30,13 @@ namespace detail {
             return object;
         }
 
-        template<typename T, typename std::enable_if<std::is_trivial<T>::value, int>::type = 0>
+        template<
+            typename T,
+            typename std::enable_if<
+                std::is_standard_layout<T>::value && std::is_trivially_copyable<T>::value,
+                int
+            >::type = 0
+        >
         Result<monostate, internal_error> read_span(span<T> items, off_t offset) {
             return read_bytes(
                 make_span(reinterpret_cast<char*>(items.data()), reinterpret_cast<char*>(items.data() + items.size())),

src/utils/span.hpp

@@ -82,7 +82,10 @@ namespace detail {
         return {begin, count};
     }
 
-    template<typename T, typename std::enable_if<std::is_trivial<T>::value && !is_span<T>::value, int>::type = 0>
+    template<
+        typename T,
+        typename std::enable_if<std::is_trivially_copyable<T>::value && !is_span<T>::value, int>::type = 0
+    >
     span<char> make_bspan(T& object) {
         return span<char>(reinterpret_cast<char*>(std::addressof(object)), sizeof(object));
     }

src/utils/utils.hpp

@@ -147,7 +147,13 @@ namespace detail {
     }
 
     // TODO: Re-evaluate use of off_t
-    template<typename T, typename std::enable_if<std::is_trivial<T>::value, int>::type = 0>
+    template<
+        typename T,
+        typename std::enable_if<
+            std::is_standard_layout<T>::value && std::is_trivially_copyable<T>::value,
+            int
+        >::type = 0
+    >
     Result<T, internal_error> load_bytes(std::FILE* object_file, off_t offset) {
         T object;
         if(std::fseek(object_file, offset, SEEK_SET) != 0) {
@@ -210,7 +216,7 @@ namespace detail {
         //  <= 19.23 msvc also appears to fail (but for a different reason https://godbolt.org/z/6Y5EvdWPK)
         //  <= 19.39 msvc also has trouble with it for different reasons https://godbolt.org/z/aPPPT7z3z
         typename std::enable_if<
-            std::is_standard_layout<T>::value && std::is_trivial<T>::value,
+            std::is_standard_layout<T>::value && std::is_trivially_copyable<T>::value,
             int
         >::type = 0,
         typename std::enable_if<