Skip to content

Commit d3da698

Browse files
authored
Update password decryption (#94)
1 parent d34f9a4 commit d3da698

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

src/main/java/com/github/terma/jenkins/githubprcoveragestatus/Configuration.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
package com.github.terma.jenkins.githubprcoveragestatus;
1919

2020
import hudson.Extension;
21+
import hudson.util.Secret;
2122
import hudson.model.AbstractDescribableImpl;
2223
import hudson.model.Descriptor;
2324
import net.sf.json.JSONObject;
@@ -188,17 +189,20 @@ public String getSonarPassword() {
188189
@Override
189190
public boolean configure(StaplerRequest req, JSONObject formData) throws FormException {
190191
gitHubApiUrl = StringUtils.trimToNull(formData.getString("gitHubApiUrl"));
191-
personalAccessToken = StringUtils.trimToNull(formData.getString("personalAccessToken"));
192+
personalAccessToken = Secret.toString(Secret.fromString(
193+
StringUtils.trimToNull(formData.getString("personalAccessToken"))));
192194
yellowThreshold = NumberUtils.toInt(formData.getString("yellowThreshold"), DEFAULT_YELLOW_THRESHOLD);
193195
greenThreshold = NumberUtils.toInt(formData.getString("greenThreshold"), DEFAULT_GREEN_THRESHOLD);
194196
jenkinsUrl = StringUtils.trimToNull(formData.getString("jenkinsUrl"));
195197
privateJenkinsPublicGitHub = BooleanUtils.toBoolean(formData.getString("privateJenkinsPublicGitHub"));
196198
useSonarForMasterCoverage = BooleanUtils.toBoolean(formData.getString("useSonarForMasterCoverage"));
197199
disableSimpleCov = BooleanUtils.toBoolean(formData.getString("disableSimpleCov"));
198200
sonarUrl = StringUtils.trimToNull(formData.getString("sonarUrl"));
199-
sonarToken = StringUtils.trimToNull(formData.getString("sonarToken"));
201+
sonarToken = Secret.toString(Secret.fromString(
202+
StringUtils.trimToNull(formData.getString("sonarToken"))));
200203
sonarLogin = StringUtils.trimToNull(formData.getString("sonarLogin"));
201-
sonarPassword = StringUtils.trimToNull(formData.getString("sonarPassword"));
204+
sonarPassword = Secret.toString(Secret.fromString(
205+
StringUtils.trimToNull(formData.getString("sonarPassword"))));
202206
save();
203207
return super.configure(req, formData);
204208
}

0 commit comments

Comments
 (0)