Skip to content

Commit 3838fa3

Browse files
committed
Issue-361: Add prudent information about a publishing of checks.
1 parent 8d17133 commit 3838fa3

File tree

2 files changed

+14
-3
lines changed

2 files changed

+14
-3
lines changed

src/main/java/io/jenkins/plugins/checks/github/GitHubChecksPublisher.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -96,9 +96,12 @@ public void publish(final ChecksDetails details) {
9696

9797
context.addActionIfMissing(run.getId(), gitHubDetails.getName());
9898

99-
buildLogger.log("GitHub check (name: %s, status: %s) has been published.", gitHubDetails.getName(),
100-
gitHubDetails.getStatus());
101-
SYSTEM_LOGGER.fine(format("Published check for repo: %s, sha: %s, job name: %s, name: %s, status: %s",
99+
buildLogger.log("GitHub check (name: %s, status: %s, url: %s) has been published.",
100+
gitHubDetails.getName(),
101+
gitHubDetails.getStatus(),
102+
gitHub.getApiUrl());
103+
SYSTEM_LOGGER.fine(format("Published check for url: %s, repo: %s, sha: %s, job name: %s, name: %s, status: %s",
104+
gitHub.getApiUrl(),
102105
context.getRepository(),
103106
context.getHeadSha(),
104107
context.getJob().getFullName(),

src/test/java/io/jenkins/plugins/checks/github/GitHubChecksPublisherITest.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -161,6 +161,8 @@ public static Collection<Object[]> contextBuilders() {
161161
*/
162162
@Test
163163
public void shouldPublishGitHubCheckRunCorrectly() {
164+
loggerRule.record(GitHubChecksPublisher.class.getName(), Level.WARNING).capture(1);
165+
164166
ChecksDetails details = new ChecksDetailsBuilder()
165167
.withName("Jenkins")
166168
.withStatus(ChecksStatus.COMPLETED)
@@ -206,6 +208,12 @@ public void shouldPublishGitHubCheckRunCorrectly() {
206208
new PluginLogger(j.createTaskListener().getLogger(), "GitHub Checks"),
207209
wireMockRule.baseUrl())
208210
.publish(details);
211+
212+
assertThat(loggerRule.getRecords().size()).isEqualTo(1);
213+
assertThat(loggerRule.getMessages().get(0))
214+
.contains("Failed Publishing GitHub checks: ")
215+
.contains("name='Jenkins'")
216+
.contains("status=COMPLETED");
209217
}
210218

211219
/**

0 commit comments

Comments
 (0)