[JENKINS-75015] Update the build status refname format used for Bitbucket Cloud (#947)

Author: nfalco79

src/main/java/com/cloudbees/jenkins/plugins/bitbucket/impl/notifier/BitbucketBuildStatusNotifications.java

@@ -234,12 +234,16 @@ private static void sendNotifications(BitbucketSCMSource source, Run<?, ?> build
             listener.getLogger().println("[Bitbucket] Notifying commit build result");
             SCMHead head = rev.getHead();
             key = getBuildKey(build, head.getName(), shareBuildKeyBetweenBranchAndPR);
-            if (rev instanceof BitbucketTagSCMRevision || head instanceof BitbucketTagSCMHead) {
-                refName = "refs/tags/" + head.getName();
+            bitbucket = source.buildBitbucketClient();
+            if (BitbucketApiUtils.isCloud(bitbucket)) {
+                refName = head.getName();
             } else {
-                refName = "refs/heads/" + head.getName();
+                if (rev instanceof BitbucketTagSCMRevision || head instanceof BitbucketTagSCMHead) {
+                    refName = "refs/tags/" + head.getName();
+                } else {
+                    refName = "refs/heads/" + head.getName();
+                }
             }
-            bitbucket = source.buildBitbucketClient();
         }
         createStatus(build, listener, bitbucket, key, hash, refName);
     }

src/main/java/com/cloudbees/jenkins/plugins/bitbucket/impl/util/BitbucketApiUtils.java

@@ -5,6 +5,7 @@
 import com.cloudbees.jenkins.plugins.bitbucket.api.BitbucketApiFactory;
 import com.cloudbees.jenkins.plugins.bitbucket.api.BitbucketAuthenticator;
 import com.cloudbees.jenkins.plugins.bitbucket.api.BitbucketRequestException;
+import com.cloudbees.jenkins.plugins.bitbucket.client.BitbucketCloudApiClient;
 import com.cloudbees.jenkins.plugins.bitbucket.endpoints.BitbucketCloudEndpoint;
 import com.cloudbees.jenkins.plugins.bitbucket.endpoints.BitbucketEndpointConfiguration;
 import com.cloudbees.plugins.credentials.CredentialsProvider;
@@ -26,7 +27,11 @@
 @Restricted(NoExternalUse.class)
 public class BitbucketApiUtils {
 
-    private static final Logger LOGGER = Logger.getLogger(BitbucketApiUtils.class.getName());
+    private static final Logger logger = Logger.getLogger(BitbucketApiUtils.class.getName());
+
+    public static boolean isCloud(BitbucketApi client) {
+        return client instanceof BitbucketCloudApiClient;
+    }
 
     public static ListBoxModel getFromBitbucket(SCMSourceOwner context,
                                                 String serverUrl,
@@ -82,10 +87,10 @@ public static ListBoxModel getFromBitbucket(SCMSourceOwner context,
                         : Messages.BitbucketSCMSource_UnauthorizedOwner(repoOwner)).withSelectionCleared();
                 }
             }
-            LOGGER.log(Level.SEVERE, e.getMessage(), e);
+            logger.log(Level.SEVERE, e.getMessage(), e);
             throw FormFillFailure.error(e.getMessage());
         } catch (Throwable e) {
-            LOGGER.log(Level.SEVERE, e.getMessage(), e);
+            logger.log(Level.SEVERE, e.getMessage(), e);
             throw FormFillFailure.error(e.getMessage());
         }
     }