Make BitbucketApi extends Autoclosable so that who get the interface is warned to close the obtained client implementation.

Author: nfalco79

src/main/java/com/cloudbees/jenkins/plugins/bitbucket/api/BitbucketApi.java

@@ -39,7 +39,7 @@
  * Provides access to a specific repository.
  * One API object needs to be created for each repository you want to work with.
  */
-public interface BitbucketApi {
+public interface BitbucketApi extends AutoCloseable {
 
     /**
      * Returns the owner name for the repository.

src/test/java/com/cloudbees/jenkins/plugins/bitbucket/impl/client/ExponentialBackOffServiceUnavailableRetryStrategyTest.java

@@ -60,7 +60,7 @@ void test_retry(ClientAndServer mockServer) throws Exception {
         );
 
         final RetryInterceptor counterInterceptor = new RetryInterceptor();
-        BitbucketApi client = new BitbucketServerAPIClient("http://localhost:" + mockServer.getPort(),
+        try (BitbucketApi client = new BitbucketServerAPIClient("http://localhost:" + mockServer.getPort(),
                 "test",
                 "testRepos",
                 (BitbucketAuthenticator) null,
@@ -73,10 +73,11 @@ protected HttpClientBuilder setupClientBuilder(String host) {
                         .setServiceUnavailableRetryStrategy(new ExponentialBackOffServiceUnavailableRetryStrategy(2, 5, 100))
                         .addInterceptorFirst(counterInterceptor);
             }
-        };
+        }) {
 
-        assertThatIOException().isThrownBy(() -> client.getTags());
-        assertThat(counterInterceptor.getRetry()).isEqualTo(6); // retry after 5ms, 10ms, 20ms, 40ms, 80ms, 100ms
+            assertThatIOException().isThrownBy(() -> client.getTags());
+            assertThat(counterInterceptor.getRetry()).isEqualTo(6); // retry after 5ms, 10ms, 20ms, 40ms, 80ms, 100ms
+        }
     }
 
     private static class RetryInterceptor implements HttpResponseInterceptor {