Skip to content

Commit 20bf6b0

Browse files
committed
run tagless-ember-components-codemod
This is the result of running the tagless-ember-components-codemod against Ember Bootstrap. The following open pull request have been merged in before: - Support native classes: ember-codemods/tagless-ember-components-codemod#44 - Support component with event handlers: ember-codemods/tagless-ember-components-codemod#52 - Support aria role for native classes: ember-codemods/tagless-ember-components-codemod#56 Steps: mv addon/templates/components/common addon/templates/components/base npx jelhan/tagless-ember-components-codemod#merged-native-class-support mv addon/templates/components/base addon/templates/components/common
1 parent e81f167 commit 20bf6b0

File tree

16 files changed

+68
-54
lines changed

16 files changed

+68
-54
lines changed

addon/components/base/bs-accordion.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { action } from '@ember/object';
2-
import { layout as templateLayout } from '@ember-decorators/component';
2+
import { layout as templateLayout, tagName } from '@ember-decorators/component';
33
import Component from '@ember/component';
44
import layout from 'ember-bootstrap/templates/components/bs-accordion';
55
import listenTo from 'ember-bootstrap/utils/cp/listen-to';
@@ -36,7 +36,7 @@ import defaultValue from 'ember-bootstrap/utils/default-decorator';
3636
@extends Ember.Component
3737
@public
3838
*/
39-
@templateLayout(layout)
39+
@tagName("")
4040
export default class Accordion extends Component {
4141
@defaultValue
4242
ariaRole = 'tablist';

addon/components/base/bs-form/element/help-text.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { layout as templateLayout } from '@ember-decorators/component';
1+
import { layout as templateLayout, tagName } from '@ember-decorators/component';
22
import Component from '@ember/component';
33
import layout from 'ember-bootstrap/templates/components/bs-form/element/help-text';
44

@@ -9,5 +9,5 @@ import layout from 'ember-bootstrap/templates/components/bs-form/element/help-te
99
@extends Ember.Component
1010
@private
1111
*/
12-
@templateLayout(layout)
12+
@tagName("")
1313
export default class FormElementHelpText extends Component {}

addon/components/base/bs-form/group.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { layout as templateLayout } from '@ember-decorators/component';
1+
import { layout as templateLayout, tagName } from '@ember-decorators/component';
22
import { notEmpty } from '@ember/object/computed';
33
import Component from '@ember/component';
44
import layout from 'ember-bootstrap/templates/components/bs-form/group';
@@ -25,7 +25,7 @@ import layout from 'ember-bootstrap/templates/components/bs-form/group';
2525
@extends Ember.Component
2626
@public
2727
*/
28-
@templateLayout(layout)
28+
@tagName("")
2929
export default class FormGroup extends Component {
3030
/**
3131
* @property classTypePrefix

addon/components/base/bs-modal/body.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { classNames, layout as templateLayout } from '@ember-decorators/component';
1+
import { layout as templateLayout, tagName } from '@ember-decorators/component';
22
import Component from '@ember/component';
33
import layout from 'ember-bootstrap/templates/components/bs-modal/body';
44

@@ -11,6 +11,5 @@ import layout from 'ember-bootstrap/templates/components/bs-modal/body';
1111
@extends Ember.Component
1212
@public
1313
*/
14-
@templateLayout(layout)
15-
@classNames('modal-body')
14+
@tagName("")
1615
export default class ModalBody extends Component {}

addon/components/base/bs-modal/footer.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
import { classNames, layout as templateLayout, tagName } from '@ember-decorators/component';
1+
import { action } from "@ember/object";
2+
import { layout as templateLayout, tagName } from '@ember-decorators/component';
23
import { notEmpty } from '@ember/object/computed';
34
import Component from '@ember/component';
45
import layout from 'ember-bootstrap/templates/components/bs-modal/footer';
@@ -13,9 +14,7 @@ import defaultValue from 'ember-bootstrap/utils/default-decorator';
1314
@extends Ember.Component
1415
@public
1516
*/
16-
@templateLayout(layout)
17-
@tagName('form')
18-
@classNames('modal-footer')
17+
@tagName("")
1918
export default class ModalFooter extends Component {
2019
/**
2120
* The title of the default close button. Will be ignored (i.e. no close button) if you provide your own block
@@ -84,7 +83,8 @@ export default class ModalFooter extends Component {
8483
* @public
8584
*/
8685

87-
submit(e) {
86+
@action
87+
handleSubmit(e) {
8888
e.preventDefault();
8989
// send to parent bs-modal component
9090
this.get('onSubmit')();

addon/components/base/bs-modal/header/close.js

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
import { attributeBindings, classNames, layout as templateLayout, tagName } from '@ember-decorators/component';
1+
import { action } from "@ember/object";
2+
import { layout as templateLayout, tagName } from '@ember-decorators/component';
23
import Component from '@ember/component';
34
import layout from 'ember-bootstrap/templates/components/bs-modal/header/close';
45
import defaultValue from 'ember-bootstrap/utils/default-decorator';
@@ -10,10 +11,7 @@ import defaultValue from 'ember-bootstrap/utils/default-decorator';
1011
@extends Ember.Component
1112
@private
1213
*/
13-
@templateLayout(layout)
14-
@tagName('button')
15-
@classNames('close')
16-
@attributeBindings('type', 'aria-label')
14+
@tagName("")
1715
export default class ModalHeaderClose extends Component {
1816
'aria-label' = 'Close';
1917

@@ -27,7 +25,8 @@ export default class ModalHeaderClose extends Component {
2725
onClick() {
2826
}
2927

30-
click() {
28+
@action
29+
handleClick() {
3130
this.get('onClick')();
3231
}
3332
}
Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { classNames, layout as templateLayout, tagName } from '@ember-decorators/component';
1+
import { layout as templateLayout, tagName } from '@ember-decorators/component';
22
import Component from '@ember/component';
33
import layout from 'ember-bootstrap/templates/components/bs-modal/header/title';
44

@@ -9,7 +9,5 @@ import layout from 'ember-bootstrap/templates/components/bs-modal/header/title';
99
@extends Ember.Component
1010
@private
1111
*/
12-
@templateLayout(layout)
13-
@tagName('h4')
14-
@classNames('modal-title')
12+
@tagName("")
1513
export default class ModalHeaderTitle extends Component {}

addon/components/base/bs-progress.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { classNames, layout as templateLayout } from '@ember-decorators/component';
1+
import { layout as templateLayout, tagName } from '@ember-decorators/component';
22
import Component from '@ember/component';
33
import layout from 'ember-bootstrap/templates/components/bs-progress';
44
import defaultValue from 'ember-bootstrap/utils/default-decorator';
@@ -36,8 +36,7 @@ import defaultValue from 'ember-bootstrap/utils/default-decorator';
3636
@extends Ember.Component
3737
@public
3838
*/
39-
@templateLayout(layout)
40-
@classNames('progress')
39+
@tagName("")
4140
export default class Progress extends Component {
4241
/**
4342
* @property progressBarComponent
Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
1-
{{yield
2-
(hash
3-
item=(component this.itemComponent selected=this.isSelected onClick=this.doChange)
4-
change=this.doChange
5-
)
6-
}}
1+
<div ...attributes>
2+
{{yield
3+
(hash
4+
item=(component this.itemComponent selected=this.isSelected onClick=this.doChange)
5+
change=this.doChange
6+
)
7+
}}
8+
</div>
Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,3 @@
1-
{{@text}}
1+
<div ...attributes>
2+
{{@text}}
3+
</div>

0 commit comments

Comments
 (0)