Freeze all Ruby string literals (#190)

ashmaroli · web-flow · commit 59e6c4b5e605 · 2020-02-10T11:03:52.000-05:00
Merge pull request 190
diff --git a/Gemfile b/Gemfile
@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 gemspec name: 'classifier-reborn'
diff --git a/Rakefile b/Rakefile
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rubygems'
 require 'rake'
 require 'rake/testtask'
diff --git a/classifier-reborn-jruby.gemspec b/classifier-reborn-jruby.gemspec
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'classifier-reborn/version'
@@ -7,7 +9,7 @@ Gem::Specification.new do |s|
   s.specification_version = 2 if s.respond_to? :specification_version=
   s.required_rubygems_version = Gem::Requirement.new('>= 0') if s.respond_to? :required_rubygems_version=
   s.rubygems_version = '2.2.2'
-  s.required_ruby_version = '>= 2.2'
+  s.required_ruby_version = '>= 2.4.0'
 
   s.name             = 'classifier-reborn-jruby'
   s.version          = ClassifierReborn::VERSION
diff --git a/classifier-reborn.gemspec b/classifier-reborn.gemspec
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'classifier-reborn/version'
@@ -6,7 +8,7 @@ Gem::Specification.new do |s|
   s.specification_version = 2 if s.respond_to? :specification_version=
   s.required_rubygems_version = Gem::Requirement.new('>= 0') if s.respond_to? :required_rubygems_version=
   s.rubygems_version = '2.2.2'
-  s.required_ruby_version = '>= 2.2'
+  s.required_ruby_version = '>= 2.4.0'
 
   s.name             = 'classifier-reborn'
   s.version          = ClassifierReborn::VERSION
diff --git a/lib/classifier-reborn.rb b/lib/classifier-reborn.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #--
 # Copyright (c) 2005 Lucas Carlson
 #
diff --git a/lib/classifier-reborn/backends/bayes_memory_backend.rb b/lib/classifier-reborn/backends/bayes_memory_backend.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ClassifierReborn
   class BayesMemoryBackend
     attr_reader :total_words, :total_trainings
diff --git a/lib/classifier-reborn/backends/bayes_redis_backend.rb b/lib/classifier-reborn/backends/bayes_redis_backend.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'no_redis_error'
 # require redis when we run #intialize. This way only people using this backend
 # will need to install and load the backend without having to
diff --git a/lib/classifier-reborn/backends/no_redis_error.rb b/lib/classifier-reborn/backends/no_redis_error.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class NoRedisError < RuntimeError
   def initialize
     msg =
diff --git a/lib/classifier-reborn/bayes.rb b/lib/classifier-reborn/bayes.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Author::    Lucas Carlson  (mailto:lucas@rufy.com)
 # Copyright:: Copyright (c) 2005 Lucas Carlson
 # License::   LGPL
diff --git a/lib/classifier-reborn/category_namer.rb b/lib/classifier-reborn/category_namer.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Author::    Lucas Carlson  (mailto:lucas@rufy.com)
 # Copyright:: Copyright (c) 2005 Lucas Carlson
 # License::   LGPL
diff --git a/lib/classifier-reborn/extensions/hasher.rb b/lib/classifier-reborn/extensions/hasher.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Author::    Lucas Carlson  (mailto:lucas@rufy.com)
 # Copyright:: Copyright (c) 2005 Lucas Carlson
 # License::   LGPL
diff --git a/lib/classifier-reborn/extensions/token_filter/stemmer.rb b/lib/classifier-reborn/extensions/token_filter/stemmer.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Author::    Lucas Carlson  (mailto:lucas@rufy.com)
 # Copyright:: Copyright (c) 2005 Lucas Carlson
 # License::   LGPL
diff --git a/lib/classifier-reborn/extensions/token_filter/stopword.rb b/lib/classifier-reborn/extensions/token_filter/stopword.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Author::    Lucas Carlson  (mailto:lucas@rufy.com)
 # Copyright:: Copyright (c) 2005 Lucas Carlson
 # License::   LGPL
diff --git a/lib/classifier-reborn/extensions/token_filter/symbol.rb b/lib/classifier-reborn/extensions/token_filter/symbol.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Author::    Lucas Carlson  (mailto:lucas@rufy.com)
 # Copyright:: Copyright (c) 2005 Lucas Carlson
 # License::   LGPL
diff --git a/lib/classifier-reborn/extensions/tokenizer/token.rb b/lib/classifier-reborn/extensions/tokenizer/token.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Author::    Lucas Carlson  (mailto:lucas@rufy.com)
 # Copyright:: Copyright (c) 2005 Lucas Carlson
 # License::   LGPL
diff --git a/lib/classifier-reborn/extensions/tokenizer/whitespace.rb b/lib/classifier-reborn/extensions/tokenizer/whitespace.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Author::    Lucas Carlson  (mailto:lucas@rufy.com)
 # Copyright:: Copyright (c) 2005 Lucas Carlson
 # License::   LGPL
diff --git a/lib/classifier-reborn/extensions/vector.rb b/lib/classifier-reborn/extensions/vector.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Author::    Ernest Ellingson
 # Copyright:: Copyright (c) 2005
 
diff --git a/lib/classifier-reborn/extensions/vector_serialize.rb b/lib/classifier-reborn/extensions/vector_serialize.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module GSL
   class Vector
     def _dump(_v)
diff --git a/lib/classifier-reborn/extensions/zero_vector.rb b/lib/classifier-reborn/extensions/zero_vector.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Vector
   def zero?
     all?(&:zero?)
diff --git a/lib/classifier-reborn/lsi.rb b/lib/classifier-reborn/lsi.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Author::    David Fayram  (mailto:dfayram@lensmen.net)
 # Copyright:: Copyright (c) 2005 David Fayram II
 # License::   LGPL
diff --git a/lib/classifier-reborn/lsi/cached_content_node.rb b/lib/classifier-reborn/lsi/cached_content_node.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Author::    Kelley Reynolds  (mailto:kelley@insidesystems.net)
 # Copyright:: Copyright (c) 2015 Kelley Reynolds
 # License::   LGPL
diff --git a/lib/classifier-reborn/lsi/content_node.rb b/lib/classifier-reborn/lsi/content_node.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Author::    David Fayram  (mailto:dfayram@lensmen.net)
 # Copyright:: Copyright (c) 2005 David Fayram II
 # License::   LGPL
diff --git a/lib/classifier-reborn/lsi/summarizer.rb b/lib/classifier-reborn/lsi/summarizer.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Author::    Lucas Carlson  (mailto:lucas@rufy.com)
 # Copyright:: Copyright (c) 2005 Lucas Carlson
 # License::   LGPL
diff --git a/lib/classifier-reborn/lsi/word_list.rb b/lib/classifier-reborn/lsi/word_list.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Author::    David Fayram  (mailto:dfayram@lensmen.net)
 # Copyright:: Copyright (c) 2005 David Fayram II
 # License::   LGPL
diff --git a/lib/classifier-reborn/validators/classifier_validator.rb b/lib/classifier-reborn/validators/classifier_validator.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ClassifierReborn
   module ClassifierValidator
     module_function
diff --git a/lib/classifier-reborn/version.rb b/lib/classifier-reborn/version.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ClassifierReborn
-  VERSION = '2.2.0'.freeze
+  VERSION = '2.2.0'
 end
diff --git a/test/backends/backend_common_tests.rb b/test/backends/backend_common_tests.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module BackendCommonTests
   def test_initial_values
     assert @backend.total_words.zero?
diff --git a/test/backends/backend_memory_test.rb b/test/backends/backend_memory_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require File.dirname(__FILE__) + '/../test_helper'
 require_relative './backend_common_tests'
 
diff --git a/test/backends/backend_redis_test.rb b/test/backends/backend_redis_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require File.dirname(__FILE__) + '/../test_helper'
 require_relative './backend_common_tests'
 
diff --git a/test/bayes/bayesian_common_benchmarks.rb b/test/bayes/bayesian_common_benchmarks.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module BayesianCommonBenchmarks
   MAX_RECORDS = 5000
 
diff --git a/test/bayes/bayesian_common_tests.rb b/test/bayes/bayesian_common_tests.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module BayesianCommonTests
   def test_good_training
     assert_equal ['love'], @classifier.train_interesting('love')
diff --git a/test/bayes/bayesian_integration_test.rb b/test/bayes/bayesian_integration_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require File.dirname(__FILE__) + '/../test_helper'
 require_relative '../data/test_data_loader'
 
diff --git a/test/bayes/bayesian_memory_benchmark.rb b/test/bayes/bayesian_memory_benchmark.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require File.dirname(__FILE__) + '/../test_helper'
 require_relative './bayesian_common_benchmarks'
 require_relative '../data/test_data_loader'
diff --git a/test/bayes/bayesian_memory_test.rb b/test/bayes/bayesian_memory_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require File.dirname(__FILE__) + '/../test_helper'
 require_relative './bayesian_common_tests'
 
diff --git a/test/bayes/bayesian_redis_benchmark.rb b/test/bayes/bayesian_redis_benchmark.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require File.dirname(__FILE__) + '/../test_helper'
 require_relative './bayesian_common_benchmarks'
 require_relative '../data/test_data_loader'
diff --git a/test/bayes/bayesian_redis_test.rb b/test/bayes/bayesian_redis_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require File.dirname(__FILE__) + '/../test_helper'
 require_relative './bayesian_common_tests'
 
diff --git a/test/data/test_data_loader.rb b/test/data/test_data_loader.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module TestDataLoader
   def self.sms_data
     @@sms_data ||= load_sms_data
diff --git a/test/extensions/hasher_test.rb b/test/extensions/hasher_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../test_helper'
 require 'tempfile'
 
diff --git a/test/extensions/matrix_test.rb b/test/extensions/matrix_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class MatrixTest < Minitest::Test
   def test_zero_division
     matrix = Matrix[[1, 0], [0, 1]]
diff --git a/test/extensions/token_filter/stemmer_test.rb b/test/extensions/token_filter/stemmer_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../test_helper'
 require 'tempfile'
 
diff --git a/test/extensions/token_filter/stopword_test.rb b/test/extensions/token_filter/stopword_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../test_helper'
 require 'tempfile'
 
diff --git a/test/extensions/token_filter/symbol_test.rb b/test/extensions/token_filter/symbol_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../test_helper'
 require 'tempfile'
 
diff --git a/test/extensions/tokenizer/token_test.rb b/test/extensions/tokenizer/token_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../test_helper'
 require 'tempfile'
 
diff --git a/test/extensions/tokenizer/whitespace_test.rb b/test/extensions/tokenizer/whitespace_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../test_helper'
 require 'tempfile'
 
diff --git a/test/extensions/zero_vector_test.rb b/test/extensions/zero_vector_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ZeroVectorTest < Minitest::Test
   def test_zero?
     vec0 = Vector[]
diff --git a/test/lsi/lsi_test.rb b/test/lsi/lsi_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require File.dirname(__FILE__) + '/../test_helper'
 
 class LSITest < Minitest::Test
diff --git a/test/lsi/word_list_test.rb b/test/lsi/word_list_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../test_helper'
 
 class WordListTest < Minitest::Test
diff --git a/test/test_helper.rb b/test/test_helper.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 $LOAD_PATH.unshift(File.dirname(__FILE__) + '/../lib')
 
 require 'minitest/autorun'
diff --git a/test/validators/classifier_validation.rb b/test/validators/classifier_validation.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require File.dirname(__FILE__) + '/../test_helper'
 require File.dirname(__FILE__) + '/../../lib/classifier-reborn/validators/classifier_validator'
 require_relative '../data/test_data_loader'

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`require 'rubygems'`
`2`	`4`	`require 'rake'`
`3`	`5`	`require 'rake/testtask'`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`#--`
`2`	`4`	`# Copyright (c) 2005 Lucas Carlson`
`3`	`5`	`#`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`module ClassifierReborn`
`2`	`4`	`class BayesMemoryBackend`
`3`	`5`	`attr_reader :total_words, :total_trainings`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`require_relative 'no_redis_error'`
`2`	`4`	`# require redis when we run #intialize. This way only people using this backend`
`3`	`5`	`# will need to install and load the backend without having to`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`class NoRedisError < RuntimeError`
`2`	`4`	`def initialize`
`3`	`5`	`msg =`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`# Author:: Lucas Carlson (mailto:lucas@rufy.com)`
`2`	`4`	`# Copyright:: Copyright (c) 2005 Lucas Carlson`
`3`	`5`	`# License:: LGPL`