Skip to content

Add cluster distro logic to the CLI #107

@jefflester

Description

@jefflester

See item 2 and the sub-items in the parent issue (copied below):

2 - Selecting the Image

Add an --image / -i option to the provision command, with valid options being trino or starburst.

minitrino provision --image trino -m mysql-event-listener
minitrino provision --image starburst -m insights

trino will be the default image type. However, it can also be set in minitrino.cfg to change it to starburst (source code).

2.1 - Enforcement / Validation

  • Handle invalid scenarios where users try to provision a Trino cluster with enterprise modules. Leverage module metadata.json files to determine whether a given module is an enterprise module or not.
  • If users deploy a Starburst cluster, require an enterprise license (this is currently not required).

2.2 - CLI Tests

CLI tests must be added to validate the newly added logic.

  • Ensure the --image option works as expected.
  • Ensure license enforcement and validation work as expected.

These tests can be added to test_cmd_provision.py (src).

Metadata

Metadata

Labels

enhancementNew feature or requesttestThings related to testing

Projects

Status

Backlog

Relationships

None yet

Development

No branches or pull requests

Issue actions