Skip to content

vfb_tovfbids no longer works for GMR lines #16

@jefferis

Description

@jefferis

There have been some changes in the preferred short form of the GMR lines. Currently the implementation looks like this:

vfbr/R/vfbids.R

Lines 44 to 57 in f347cf7

vfb_tovfbids<-function(ids, fixed=TRUE, ...){
query_field=ifelse(fixed, "label_s:", "label:")
q=paste0(query_field, ids, collapse = " ")
rdf=vfb_solr_query(filterquery="VFB_*",query=q, fields = "short_form+label", rows = Inf, ...)
if(nrow(rdf)==0) {
if(fixed) rep(NA_character_, length(ids)) else character()
} else if(fixed){
# make sure results are in correct order with NAs for missing results
rdf$short_form[match(ids, rdf$label)]
} else {
# wild card results - ordering/missing values undefined
rdf$short_form
}
}

I feel like it would make sense to search the synonym field also

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions