Skip to content

Commit eeed135

Browse files
committed
Merge branch 'master' into angular_rework_development
2 parents 7f4e1ce + b067590 commit eeed135

File tree

19 files changed

+93
-82
lines changed

19 files changed

+93
-82
lines changed

config/checkstyle/checkstyle.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -339,4 +339,10 @@
339339
<property name="message" value="core() should be used with these methods" />
340340
<property name="id" value="CoreMethodsUnused_Error" />
341341
</module>
342+
<module name="RegexpSingleline">
343+
<property name="severity" value="error" />
344+
<property name="format" value="\.is\((true|false)\)\)" />
345+
<property name="message" value="Matcher.is(true/false) should be used with error message" />
346+
<property name="id" value="MatcherBooleanWithoutMessage_Error" />
347+
</module>
342348
</module>

jdi-light-material-ui/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
<artifactId>jdi-light-material-ui</artifactId>
88
<packaging>jar</packaging>
9-
<name>JDI Material UI Elements v4</name>
9+
<name>JDI Light Material UI Elements v4</name>
1010
<version>1.5.3-SNAPSHOT</version>
1111
<groupId>com.epam.jdi</groupId>
1212
<url>https://github.com/jdi-testing</url>

jdi-light-material-ui/src/main/java/com/epam/jdi/light/material/asserts/inputs/TextFieldAssert.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public TextFieldAssert helperText(Matcher<String> condition) {
6262
*/
6363
@JDIAction("Assert that '{name}' has helper text")
6464
public TextFieldAssert hasHelperText() {
65-
jdiAssert(element().hasHelperText(), Matchers.is(true));
65+
jdiAssert(element().hasHelperText(), Matchers.is(true), "TextField doesn't have helper text");
6666
return this;
6767
}
6868

jdi-light-vuetify/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
<artifactId>jdi-light-vuetify</artifactId>
88
<packaging>jar</packaging>
9-
<name>JDI Vuetify</name>
9+
<name>JDI Light Vuetify</name>
1010
<version>1.5.3-SNAPSHOT</version>
1111
<groupId>com.epam.jdi</groupId>
1212
<url>https://github.com/jdi-testing</url>

jdi-light-vuetify/src/main/java/com/epam/jdi/light/vuetify/asserts/AutocompleteAssert.java

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,63 +16,69 @@ public class AutocompleteAssert extends UIAssert<AutocompleteAssert, Autocomplet
1616
public AutocompleteAssert expanded() {
1717
new Timer(base().getTimeout() * 1000L)
1818
.wait(() -> element().listItems().isDisplayed());
19-
jdiAssert(element().isExpanded(), Matchers.is(true));
19+
jdiAssert(element().isExpanded(), Matchers.is(true), "Autocomplete is not expanded");
2020
return this;
2121
}
2222

2323
@JDIAction("Assert that '{name}' is closed")
2424
public AutocompleteAssert closed() {
2525
new Timer(base().getTimeout() * 1000L)
2626
.wait(() -> element().root().isDisplayed());
27-
jdiAssert(element().isExpanded(), Matchers.is(false));
27+
jdiAssert(element().isExpanded(), Matchers.is(false), "Autocomplete is not closed");
2828
return this;
2929
}
3030

3131
@JDIAction("Assert that '{name}' is selected")
3232
public AutocompleteAssert selected(String value) {
3333
new Timer(base().getTimeout() * 1000L)
3434
.wait(() -> element().value().isDisplayed());
35-
jdiAssert(element().isSelected(value), Matchers.is(true));
35+
jdiAssert(element().isSelected(value), Matchers.is(true),
36+
"Autocomplete value " + value + " is not selected");
3637
return this;
3738
}
3839

40+
// TODO fix this assertion and create a method to get the list of selected elements
3941
@JDIAction("Assert that '{name}' is selected")
4042
public AutocompleteAssert selected(List<String> values) {
4143
new Timer(base().getTimeout() * 1000L)
4244
.wait(() -> element().value().isDisplayed());
43-
jdiAssert(element().isSelected(values), Matchers.is(true));
45+
jdiAssert(element().isSelected(values), Matchers.is(true), "Autocomplete doesn't have selected value");
4446
return this;
4547
}
4648

4749
@JDIAction("Assert that '{name}' is not selected")
4850
public AutocompleteAssert notSelected(String value) {
4951
new Timer(base().getTimeout() * 1000L)
5052
.wait(() -> element().isDisplayed());
51-
jdiAssert(element().isSelected(value), Matchers.is(false));
53+
jdiAssert(element().isSelected(value), Matchers.is(false),
54+
"Autocomplete doesn't have selected value " + value);
5255
return this;
5356
}
5457

5558
@JDIAction("Assert that '{name}' is not selected")
5659
public AutocompleteAssert notSelected(List<String> values) {
5760
new Timer(base().getTimeout() * 1000L)
5861
.wait(() -> element().isDisplayed());
59-
jdiAssert(element().isSelected(values), Matchers.is(false));
62+
jdiAssert(element().isSelected(values), Matchers.is(false),
63+
"Autocomplete doesn't have selected values ");
6064
return this;
6165
}
6266

6367
@JDIAction("Assert that '{name}' is disabled")
6468
public AutocompleteAssert disabled() {
6569
new Timer(base().getTimeout() * 1000L)
6670
.wait(() -> element().isDisplayed());
67-
jdiAssert(element().isDisabled(), Matchers.is(true));
71+
jdiAssert(element().isDisabled(), Matchers.is(true),
72+
"Autocomplete is not disabled");
6873
return this;
6974
}
7075

7176
@JDIAction("Assert that '{name}' is expanded")
7277
public AutocompleteAssert active() {
7378
new Timer(base().getTimeout() * 1000L)
7479
.wait(() -> element().isDisplayed());
75-
jdiAssert(element().isDisabled(), Matchers.is(false));
80+
jdiAssert(element().isDisabled(), Matchers.is(false),
81+
"Autocomplete is not active");
7682
return this;
7783
}
7884

jdi-light-vuetify/src/main/java/com/epam/jdi/light/vuetify/asserts/IconAssert.java

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,18 +18,11 @@ public class IconAssert extends UIAssert<IconAssert, Icon> implements
1818
AlignmentAssert<IconAssert, Icon>, ThemeAssert<IconAssert, Icon>,
1919
MeasurementAssert<IconAssert, Icon>, ColorAssert<IconAssert, Icon> {
2020

21-
@JDIAction("Assert that '{name}' is displayed")
22-
public IconAssert displayed() {
23-
Timer.waitCondition(element()::isDisplayed);
24-
jdiAssert(element().isDisplayed(), Matchers.is(true));
25-
return this;
26-
}
27-
2821
@JDIAction("Assert that '{name}' is clickable")
2922
public IconAssert clickable() {
3023
Timer.waitCondition(element()::isDisplayed);
31-
jdiAssert(element().core().isClickable() ? "is clickable" : "is not clickable",
32-
Matchers.is("is clickable"));
24+
jdiAssert(element().core().isClickable(),
25+
Matchers.is(true), "Icon is not clickable");
3326
return this;
3427
}
3528

jdi-light-vuetify/src/main/java/com/epam/jdi/light/vuetify/asserts/MenuAssert.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public class MenuAssert extends UIAssert<MenuAssert, Menu> implements ThemeAsser
1616
@JDIAction("Assert that '{name}' is displayed")
1717
public MenuAssert displayed() {
1818
Timer.waitCondition(element()::isDisplayed);
19-
jdiAssert(element().isDisplayed(), Matchers.is(true));
19+
jdiAssert(element().isDisplayed(), Matchers.is(true), "Menu is not displayed");
2020
return this;
2121
}
2222

jdi-light-vuetify/src/main/java/com/epam/jdi/light/vuetify/asserts/NavigationDrawerAssert.java

Lines changed: 30 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import com.epam.jdi.light.vuetify.elements.complex.NavigationDrawer;
66
import com.epam.jdi.light.vuetify.interfaces.asserts.ThemeAssert;
77
import com.jdiai.tools.Timer;
8+
import org.hamcrest.Matcher;
89
import org.hamcrest.Matchers;
910

1011
import java.util.List;
@@ -14,13 +15,6 @@
1415
public class NavigationDrawerAssert extends UIAssert<NavigationDrawerAssert, NavigationDrawer>
1516
implements ThemeAssert<NavigationDrawerAssert, NavigationDrawer> {
1617

17-
@JDIAction("Assert that '{name}' is displayed")
18-
public NavigationDrawerAssert displayed() {
19-
Timer.waitCondition(element()::isDisplayed);
20-
jdiAssert(element().isDisplayed(), Matchers.is(true));
21-
return this;
22-
}
23-
2418
@JDIAction("Assert that '{name}' has expected number of items")
2519
public NavigationDrawerAssert itemSize(int value) {
2620
jdiAssert(element().size(), Matchers.is(value));
@@ -30,39 +24,39 @@ public NavigationDrawerAssert itemSize(int value) {
3024
@JDIAction("Assert that '{name}' is collapsed")
3125
public NavigationDrawerAssert collapsed() {
3226
Timer.waitCondition(element()::isCollapsed);
33-
jdiAssert(element().isCollapsed() ? "is collapsed" : "is expanded",
34-
Matchers.is("is collapsed"));
27+
jdiAssert(element().isCollapsed(),
28+
Matchers.is(true), "NavigationDrawer is not collapsed");
3529
return this;
3630
}
3731

3832
@JDIAction("Assert that '{name}' is expanded")
3933
public NavigationDrawerAssert expanded() {
4034
Timer.waitCondition(element()::isExpanded);
41-
jdiAssert(element().isExpanded() ? "is expanded" : "is collapsed",
42-
Matchers.is("is expanded"));
35+
jdiAssert(element().isExpanded(),
36+
Matchers.is(true), "NavigationDrawer is not expanded");
4337
return this;
4438
}
4539

4640
@JDIAction("Assert that '{name}' is opened")
4741
public NavigationDrawerAssert opened() {
4842
Timer.waitCondition(element()::isOpened);
49-
jdiAssert(element().isOpened() ? "is opened" : "is closed",
50-
Matchers.is("is opened"));
43+
jdiAssert(element().isOpened(),
44+
Matchers.is(true), "NavigationDrawer is not opened");
5145
return this;
5246
}
5347

5448
@JDIAction("Assert that '{name}' is closed")
5549
public NavigationDrawerAssert closed() {
5650
Timer.waitCondition(element()::isClosed);
57-
jdiAssert(element().isClosed() ? "is closed" : "is opened",
58-
Matchers.is("is closed"));
51+
jdiAssert(element().isClosed(),
52+
Matchers.is(true), "NavigationDrawer is not closed");
5953
return this;
6054
}
6155

6256
@JDIAction("Assert that '{name}' is located on the right side")
6357
public NavigationDrawerAssert right() {
64-
jdiAssert(element().isRight() ? "is on the right side" : "is on the left side",
65-
Matchers.is("is on the right side"));
58+
jdiAssert(element().isRight(),
59+
Matchers.is(true), "NavigationDrawer is not on right side");
6660
return this;
6761
}
6862

@@ -74,32 +68,39 @@ public NavigationDrawerAssert backgroundColor(String color) {
7468

7569
@JDIAction("Check '{name}' text of items")
7670
public NavigationDrawerAssert text(List<String> values) {
77-
jdiAssert(element().itemsText().equals(values), Matchers.is(true));
71+
text(Matchers.containsInAnyOrder(values));
72+
text(Matchers.hasSize(values.size()));
73+
return this;
74+
}
75+
76+
@JDIAction("Check '{name}' text of items using specific condition")
77+
public NavigationDrawerAssert text(Matcher<? super List<String>> condition) {
78+
jdiAssert(element().itemsText(), condition);
7879
return this;
7980
}
8081

8182
@JDIAction("Assert that '{name}' is absolute")
8283
public NavigationDrawerAssert absolute() {
83-
jdiAssert(element().isAbsolute() ? "is absolute" : "is not absolute", Matchers.is("is absolute"));
84+
jdiAssert(element().isAbsolute(), Matchers.is(true), "NavigationDrawer is not absolute");
8485
return this;
8586
}
8687

8788
@JDIAction("Assert that '{name}' is bottom")
8889
public NavigationDrawerAssert bottom() {
89-
jdiAssert(element().isBottom() ? "is bottom" : "is not bottom", Matchers.is("is bottom"));
90+
jdiAssert(element().isBottom(), Matchers.is(true), "NavigationDrawer is not in bottom");
9091
return this;
9192
}
9293

9394
@JDIAction("Assert that '{name}' is clipped")
9495
public NavigationDrawerAssert clipped() {
95-
jdiAssert(element().isClipped() ? "is clipped" : "is not clipped", Matchers.is("is clipped"));
96+
jdiAssert(element().isClipped(), Matchers.is(true), "NavigationDrawer is not clipped");
9697
return this;
9798
}
9899

99100
@JDIAction("Assert that theme of '{name}' is floating")
100101
public NavigationDrawerAssert floating() {
101-
jdiAssert(element().isFloating() ? "is floating" : "is not floating",
102-
Matchers.is("is floating"));
102+
jdiAssert(element().isFloating(),
103+
Matchers.is(true), "NavigationDrawer is not floating");
103104
return this;
104105
}
105106

@@ -117,20 +118,20 @@ public NavigationDrawerAssert width(int width) {
117118

118119
@JDIAction("Assert that theme of '{name}' is temporary")
119120
public NavigationDrawerAssert temporary() {
120-
jdiAssert(element().isTemporary() ? "is temporary" : "permanent", Matchers.is("is temporary"));
121+
jdiAssert(element().isTemporary(), Matchers.is(true), "NavigationDrawer is not temporary");
121122
return this;
122123
}
123124

124125
@JDIAction("Assert that theme of '{name}' is permanent")
125126
public NavigationDrawerAssert permanent() {
126-
jdiAssert(element().isTemporary() ? "is temporary" : "permanent", Matchers.is("permanent"));
127+
jdiAssert(element().isTemporary(), Matchers.is(false), "NavigationDrawer is temporary");
127128
return this;
128129
}
129130

130131
@JDIAction("Assert that theme of '{name}' is mini-variant")
131132
public NavigationDrawerAssert miniVariant() {
132-
jdiAssert(element().isMiniVariant() ? "is mini-variant" : "is not mini-variant",
133-
Matchers.is("is mini-variant"));
133+
jdiAssert(element().isMiniVariant(),
134+
Matchers.is(true), "NavigationDrawer is not mini-variant");
134135
return this;
135136
}
136137

@@ -150,8 +151,8 @@ public NavigationDrawerAssert noOverlay() {
150151

151152
@JDIAction("Assert that theme of '{name}' is expanded on hover")
152153
public NavigationDrawerAssert expandedOnHover() {
153-
jdiAssert(element().isExpandedOnHover() ? "is expanded on hover" : "is not expanded on hover",
154-
Matchers.is("is expanded on hover"));
154+
jdiAssert(element().isExpandedOnHover(),
155+
Matchers.is(true), "NavigationDrawer is not expanded on hover");
155156
return this;
156157
}
157158

jdi-light-vuetify/src/main/java/com/epam/jdi/light/vuetify/asserts/PaginationAssert.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,13 @@ public PaginationAssert atEnd() {
3131

3232
@JDIAction("Assert that '{name}' is circle")
3333
public PaginationAssert circle() {
34-
jdiAssert(element().isCircle() ? "circle" : "not circle", Matchers.is("circle"));
34+
jdiAssert(element().isCircle(), Matchers.is(true), "Pagination is not circle");
3535
return this;
3636
}
3737

3838
@JDIAction("Assert that '{name}' is not circle")
3939
public PaginationAssert notCircle() {
40-
jdiAssert(element().isCircle() ? "circle" : "not circle", Matchers.is("not circle"));
40+
jdiAssert(element().isCircle(), Matchers.is(false), "Pagination is circle");
4141
return this;
4242
}
4343

@@ -65,14 +65,14 @@ public PaginationAssert nextAriaLabel() {
6565
@JDIAction("Assert that '{name}' next icon has value '{0}'")
6666
public PaginationAssert nextIcon(String icon) {
6767
jdiAssert(element().nextIcon().hasClass(icon),
68-
Matchers.is(true));
68+
Matchers.is(true), "Paginator next icon is not " + icon);
6969
return this;
7070
}
7171

7272
@JDIAction("Assert that '{name}' next icon has value '{0}'")
7373
public PaginationAssert previousIcon(String icon) {
7474
jdiAssert(element().previousIcon().hasClass(icon),
75-
Matchers.is(true));
75+
Matchers.is(true), "Paginator previous icon is not " + icon);
7676
return this;
7777
}
7878

jdi-light-vuetify/src/main/java/com/epam/jdi/light/vuetify/asserts/RangeSliderAssert.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,13 +68,15 @@ public RangeSliderAssert thumbLabelValue(String leftValue, String rightValue) {
6868

6969
@JDIAction("Assert that thumb label {name} is displayed")
7070
public RangeSliderAssert thumbLabelDisplayed() {
71-
jdiAssert(element().isThumbLabelDisplayed(), Matchers.is(true));
71+
jdiAssert(element().isThumbLabelDisplayed(), Matchers.is(true),
72+
"RangeSlider's thumb label is not displayed");
7273
return this;
7374
}
7475

7576
@JDIAction("Assert that thumb label {name} is not displayed")
7677
public RangeSliderAssert thumbLabelNotDisplayed() {
77-
jdiAssert(element().isThumbLabelDisplayed(), Matchers.is(false));
78+
jdiAssert(element().isThumbLabelDisplayed(), Matchers.is(false),
79+
"RangeSlider's thumb label is displayed");
7880
return this;
7981
}
8082

0 commit comments

Comments
 (0)