Skip to content

Commit 680dbe2

Browse files
authored
Merge pull request #5286 from jdi-testing/fix_npe_cookies
Add debug info for errors
2 parents de5cda4 + fc98b33 commit 680dbe2

File tree

15 files changed

+17
-17
lines changed

15 files changed

+17
-17
lines changed

jdi-bdd-tests/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
<profile>
2727
<id>jdk16</id>
2828
<activation>
29-
<jdk>[16, 20]</jdk>
29+
<jdk>[16,)</jdk>
3030
</activation>
3131
<properties>
3232
<aspectj.args>--add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.lang.reflect=ALL-UNNAMED --add-opens=java.base/java.text=ALL-UNNAMED --add-opens=java.desktop/java.awt.font=ALL-UNNAMED</aspectj.args>

jdi-light-angular-tests-with-mocks/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
<profile>
2626
<id>jdk16</id>
2727
<activation>
28-
<jdk>[16, 20]</jdk>
28+
<jdk>[16,)</jdk>
2929
</activation>
3030
<properties>
3131
<aspectj.args>--add-opens java.base/java.lang=ALL-UNNAMED</aspectj.args>

jdi-light-angular-tests/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@
146146
<profile>
147147
<id>jdk16</id>
148148
<activation>
149-
<jdk>[16, 20]</jdk>
149+
<jdk>[16,)</jdk>
150150
</activation>
151151
<properties>
152152
<aspectj.args>--add-opens java.base/java.lang=ALL-UNNAMED</aspectj.args>

jdi-light-applitools-tests/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
<profile>
3131
<id>jdk16</id>
3232
<activation>
33-
<jdk>[16, 20]</jdk>
33+
<jdk>[16,)</jdk>
3434
</activation>
3535
<properties>
3636
<aspectj.args>--add-opens java.base/java.lang=ALL-UNNAMED</aspectj.args>

jdi-light-bootstrap-tests/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
<profile>
2727
<id>jdk16</id>
2828
<activation>
29-
<jdk>[16, 20]</jdk>
29+
<jdk>[16,)</jdk>
3030
</activation>
3131
<properties>
3232
<aspectj.args>--add-opens java.base/java.lang=ALL-UNNAMED</aspectj.args>

jdi-light-core/src/main/java/com/epam/jdi/light/actions/ActionHelper.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -395,7 +395,7 @@ public static RuntimeException actionFailed(ActionObject jInfo, Throwable ex) {
395395
}
396396
addFailedMethod(jInfo.jp());
397397
if (jInfo.topLevel()) {
398-
logFailure(jInfo);
398+
logFailure(jInfo, ex);
399399
reverse(failedMethods);
400400
List<String> chainActions = new ArrayList<>(failedMethods);
401401
try {
@@ -415,8 +415,7 @@ public static RuntimeException actionFailed(ActionObject jInfo, Throwable ex) {
415415

416416
public static JFunc2<ActionObject, Throwable, RuntimeException> ACTION_FAILED = ActionHelper::actionFailed;
417417

418-
public static void logFailure(ActionObject jInfo) {
419-
logger.error("!>>> " + jInfo.object().toString());
418+
public static void logFailure(ActionObject jInfo, Throwable ex) {
420419
if (ObjectUtils.isNotEmpty(ELEMENT.highlight) && !ELEMENT.highlight.contains(HighlightStrategy.OFF)) {
421420
if (ELEMENT.highlight.contains(HighlightStrategy.FAIL)) {
422421
try {
@@ -427,6 +426,7 @@ public static void logFailure(ActionObject jInfo) {
427426
showElement(jInfo);
428427
AllureLogData logData = logDataToAllure(FAIL,
429428
"Failed" + capitalize(jInfo.methodName()), jInfo.isAssert());
429+
logger.error("!>>> " + jInfo.object().toString() + " Failed " + capitalize(jInfo.methodName()), ex);
430430
failStep(jInfo.stepUId, logData);
431431
}
432432

jdi-light-html-tests/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@
135135
<profile>
136136
<id>jdk16</id>
137137
<activation>
138-
<jdk>[16, 20]</jdk>
138+
<jdk>[16,)</jdk>
139139
</activation>
140140
<properties>
141141
<aspectj.args>--add-opens java.base/java.lang=ALL-UNNAMED</aspectj.args>

jdi-light-material-ui-tests/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@
118118
<profile>
119119
<id>jdk16</id>
120120
<activation>
121-
<jdk>[16, 20]</jdk>
121+
<jdk>[16,)</jdk>
122122
</activation>
123123
<properties>
124124
<aspectj.args>--add-opens java.base/java.lang=ALL-UNNAMED</aspectj.args>

jdi-light-mobile-selenium3-tests/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
<profile>
3434
<id>jdk16</id>
3535
<activation>
36-
<jdk>[16, 20]</jdk>
36+
<jdk>[16,)</jdk>
3737
</activation>
3838
<properties>
3939
<aspectj.args>--add-opens java.base/java.lang=ALL-UNNAMED</aspectj.args>

jdi-light-mobile-tests/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
<profile>
3535
<id>jdk16</id>
3636
<activation>
37-
<jdk>[16, 20]</jdk>
37+
<jdk>[16,)</jdk>
3838
</activation>
3939
<properties>
4040
<aspectj.args>--add-opens java.base/java.lang=ALL-UNNAMED</aspectj.args>

0 commit comments

Comments
 (0)