Merge branch 'master' into angular_rework_development

# Conflicts:
#	jdi-light-angular-tests/src/test/java/io/github/epam/angular/tests/elements/common/BasicButtonTests.java

Author: pnatashap

README.md

@@ -2,6 +2,7 @@
 
 [![License: MIT](https://img.shields.io/badge/License-MIT-green.svg)](https://mit-license.org/)
 [![stackoverflow](https://img.shields.io/badge/stackoverflow-jdi-blue.svg?style=flat)](http://stackoverflow.com/questions/tagged/jdi)
+[![PDD Status](https://www.0pdd.com/svg?name=jdi-testing/jdi-light)](https://www.0pdd.com/p?name=jdi-testing/jdi-light)
 [![FOSSA Status](https://app.fossa.io/api/projects/git%2Bgithub.com%2Fjdi-testing%2Fjdi-light.svg?type=shield)](https://app.fossa.io/projects/git%2Bgithub.com%2Fjdi-testing%2Fjdi-light?ref=badge_shield)
 [![SLACK](https://img.shields.io/badge/slack-community-green.svg)](https://join.slack.com/t/jdi-family/shared_invite/zt-toag8fgg-ppPiW~lZDU9873JAiSwTJw)
 ## Important

config/checkstyle/checkstyle.xml

@@ -308,41 +308,55 @@
     <property name="format" value="\s+$" />
     <property name="message" value="Line has trailing spaces" />
     <property name="id" value="TrailingSpaces_Error" />
+    <property name="fileExtensions" value="java"/>
   </module>
   <module name="RegexpSingleline">
     <property name="severity" value="error" />
     <property name="format" value="\.exit\(|\.halt\(|\.traceMethodCalls\(|\.traceInstructions\(|\.runFinalization\(|\.gc\(" />
     <property name="message" value="Suspicious invocation of dangerous JVM level operation" />
     <property name="id" value="DangerousJVMOperation_Error" />
+    <property name="fileExtensions" value="java"/>
   </module>
   <module name="RegexpSingleline">
     <property name="severity" value="error" />
     <property name="format" value="long serialVersionUID" />
     <property name="message" value="Do not declare a serialVersionUID" />
     <property name="id" value="SerialVersionUIDDeclared_Error" />
+    <property name="fileExtensions" value="java"/>
   </module>
   <module name="RegexpSingleline">
     <property name="severity" value="error" />
     <property name="format" value="\.printStackTrace\(\)|System\.out|System\.err|org\.apache\.commons\.logging\.Log|java\.util\.logging" />
     <property name="message" value="use SLF4J for logging" />
     <property name="id" value="InvalidLoggingMethod_Error" />
+    <property name="fileExtensions" value="java"/>
   </module>
   <module name="RegexpSingleline">
     <property name="severity" value="error" />
     <property name="format" value="null !=|null ==" />
     <property name="message" value="Check for null in reverse order" />
     <property name="id" value="ReverseOrderNullCheck_Error" />
+    <property name="fileExtensions" value="java"/>
   </module>
   <module name="RegexpSingleline">
     <property name="severity" value="error" />
     <property name="format" value="(?&lt;!\.)(css|hasClass|hasAttribute|attr|find|finds)\((?!@|\)|String)" />
     <property name="message" value="core() should be used with these methods" />
     <property name="id" value="CoreMethodsUnused_Error" />
+    <property name="fileExtensions" value="java"/>
   </module>
   <module name="RegexpSingleline">
     <property name="severity" value="error" />
     <property name="format" value="\.is\((true|false)\)\)" />
     <property name="message" value="Matcher.is(true/false) should be used with error message" />
     <property name="id" value="MatcherBooleanWithoutMessage_Error" />
+    <property name="fileExtensions" value="java"/>
+  </module>
+  <module name="RegexpSingleline">
+    <property name="severity" value="error" />
+    <property name="format" value="throw new RuntimeExc" />
+    <property name="message" value="Use `throw runtimeException('Error Message')` or `throw exception('Error message')`" />
+    <property name="id" value="MatcherThrowingExceptions_Error" />
+    <property name="fileExtensions" value="java"/>
   </module>
 </module>

jdi-bdd-tests/src/main/java/io/github/com/pages/MetalAndColorsPage.java

@@ -9,8 +9,7 @@
 import com.epam.jdi.light.ui.html.elements.complex.MultiSelector;
 
 public class MetalAndColorsPage extends WebPage {
-    // TODO simple html dropdowns
-	@UI(".uui-side-bar[name='log-sidebar']") public static LogSidebar logSidebar;
+    @UI(".uui-side-bar[name='log-sidebar']") public static LogSidebar logSidebar;
 	@JDropdown(root = "div[ui=dropdown]", value = ".filter-option",
 			   list = "li", expand = ".caret")
 	public static Dropdown colors;

jdi-light-angular-tests/src/test/java/io/github/epam/angular/tests/elements/common/BasicButtonTests.java

@@ -16,19 +16,13 @@ public class RadioButtons extends com.epam.jdi.light.ui.html.elements.complex.Ra
 
     @Override
     public WebList list() {
-        WebList radioBtnWebList = new WebList(base()).setup(b -> b.setSearchRule("Any", ANY_ELEMENT))
+        return new WebList(base()).setup(b -> b.setSearchRule("Any", ANY_ELEMENT))
                 .setUIElementName(LABEL);
-        // TODO REFACTOR
-        //radioBtnWebList.setClickArea(ACTION_CLICK);
-        return radioBtnWebList;
     }
 
     public WebList list(JFunc1<WebElement, Boolean> searchRule, ElementArea elementArea) {
-        WebList radioBtnWebList = new WebList(base()).setup(jdiB -> jdiB.setSearchRule("UNDEFINED", searchRule))
+        return new WebList(base()).setup(jdiB -> jdiB.setSearchRule("UNDEFINED", searchRule))
                 .setUIElementName(LABEL);
-        // TODO REFACTOR
-        //radioBtnWebList.setClickArea(elementArea);
-        return radioBtnWebList;
     }
 
 }

jdi-light-bootstrap/src/main/java/com/epam/jdi/light/ui/bootstrap/elements/complex/RadioButtons.java

@@ -56,7 +56,6 @@ protected int getRowsCount() {
             return rows.get().size();
         if (columns.get().any())
             return columns.get().get(0).value.size();
-        // TODO
         return column(startIndex.get()).size();
     }
     protected int getTableSize() {
@@ -84,7 +83,7 @@ public WebList headerUI() {
             }
             return $$(header, headerName);
         }
-        // TODO
+
         WebList firstRow = getRowByIndex(startIndex.get());
         if (firstRow.size() > 0) {
             this.header.setRule(() -> getRowByIndex(1).values());

jdi-light-core/src/main/java/com/epam/jdi/light/elements/complex/table/SmartTable.java

@@ -95,7 +95,6 @@ public static boolean hasDomain() {
     }
 
     public static String TEST_GROUP = "";
-    // TODO multi properties example
     public static Safe<String> TEST_NAME = new Safe<>((String) null);
     public static String useDriver(JFunc<WebDriver> driver) {
         return WebDriverFactory.useDriver(driver);

jdi-light-core/src/main/java/com/epam/jdi/light/settings/WebSettings.java

@@ -47,14 +47,11 @@ public class StaticSite {
 	@Css("[ui=label]") public static UIElement navigationElement;
 	@WaitAfterAction
 	@UI("//*[@ui='label']//*[contains(text(),'%s')]") public static WebList navigationS;
-	//TODO
-	//@UI("[ui=label][*'%s']") public static WebList navigationS;
+
 	@UI(".sidebar-menu [ui=label]") public static Menu leftMenu;
-	//TODO
-	//@UI(".sidebar-menu span<[*'%s']<<") public static Menu leftMenu;
+
 	@UI("//*[contains(@class,'sidebar-menu')]//span/..//*[text()='%s']/../..") public static WebList leftMenuList;
-	//TODO
-	//@UI(".sidebar-menu span<[*'%s']<<") public static WebList leftMenuList;
+
 	@UI(".sidebar-menu span") public static JList<MenuItem> menu;
 	@NoInheritance
 	@JMenu({"[ui=label][*'%s']", "[ui=label][*'%s']"}) public static Menu2D leftMenu2D;

jdi-light-html-tests/src/main/java/io/github/com/StaticSite.java

@@ -26,66 +26,56 @@ public void before() {
     }
     String text = "Github JDI";
 
-    //TODO Performance issue
     @Test
     public void getTextTest() {
         assertEquals(githubLink.getText(), text);
     }
 
-    //TODO Performance issue
     @Test
     public void getValueTest() {
         assertEquals(githubLink.getValue(), text);
     }
 
-    //TODO Performance issue
     @Test
     public void getRefTest() {
         assertEquals(githubLink.ref(), "https://github.com/jdi-testing");
     }
 
-    //TODO Performance issue
     @Test
     public void getUrlTest() {
         assertEquals(githubLink.url().getPath(), "/jdi-testing");
     }
 
-    //TODO Performance issue
     @Test
     public void getAltTest() {
         assertEquals(githubLink.alt(), "Github JDI Link");
     }
 
-    //TODO Performance issue
     @Test
     public void clickTest() {
         githubLink.click();
         assertEquals(getUrl(), "https://github.com/jdi-testing");
         html5Page.open();
     }
 
-    //TODO Performance issue
     @Test
     public void isValidationTest() {
         githubLink.is().text(is(text));
         githubLink.is().text(equalToIgnoringCase("Github jdi"));
         githubLink.is().enabled();
     }
 
-    //TODO Performance issue
     @Test
     public void linkValidationTest() {
         githubLink.is().ref(containsString("github"));
         githubLink.is().alt(containsString("JDI"));
     }
 
-    //TODO Performance issue
     @Test
     public void assertValidationTest() {
         githubLink.assertThat().text(is(text));
     }
 
-    //TODO Performance issue
     @Test
     public void baseValidationTest() {
         baseValidation(githubLink);

jdi-light-html-tests/src/test/java/io/github/epam/html/tests/elements/common/LinkTests.java

@@ -80,7 +80,6 @@ public void placeholderTest() {
         assertEquals(yourName.placeholder(), "Input name");
     }
 
-    //TODO Performance issue
     @Test
     public void disabledTest() {
         try {