Skip to content

Commit 2b7e1ab

Browse files
TimothyGubitinn
authored andcommitted
Refine README example (node-fetch#463)
This reverts commit fa6548e (node-fetch#441). The autoClose option has been true by default since at least Node.js v6.0.0. There is no need to set it once more. Instead, make the example more realistic by handling stream outcomes using a promise. See node-fetch#375.
1 parent 5bc23d8 commit 2b7e1ab

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

README.md

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,10 +80,19 @@ fetch('http://domain.invalid/')
8080

8181
fetch('https://assets-cdn.github.com/images/modules/logos_page/Octocat.png')
8282
.then(res => {
83-
const dest = fs.createWriteStream('./octocat.png', {
84-
autoClose: true,
83+
return new Promise((resolve, reject) => {
84+
const dest = fs.createWriteStream('./octocat.png');
85+
res.body.pipe(dest);
86+
res.body.on('error', err => {
87+
reject(err);
88+
});
89+
dest.on('finish', () => {
90+
resolve();
91+
});
92+
dest.on('error', err => {
93+
reject(err);
94+
});
8595
});
86-
res.body.pipe(dest);
8796
});
8897

8998
// buffer

0 commit comments

Comments
 (0)