-
Notifications
You must be signed in to change notification settings - Fork 133
Description
Reading the code it seems that the target temperature is updated according to the runtime (oven.py:update_target_temp). As far as I've understood, the reaching the correct temperatures is more important than the time it got to get there in firing. Thus, IMO it would make more sense to only move to the next step when the target temperature has been reached. I suppose it is possible to get closer to the target by setting a small value to the pid_control_window
and using the kiln_must_catch_up
setting, but that will cause over and undershooting the profile if the PID has not been tuned very precisely.
I think it would make more sense to wait until the target temperature has been reached (i.e. temperature is higher than the target if heating, lower than target if cooling) before progressing to the next step. In order for this to be safe, however, a timeout should probably also be introduced.
I am willing to put in effort to implement this if it's deemed viable.