Merge pull request #3 from JaeYeopHan/fix/eslint-rules

Fix/eslint rules

Author: jbee37142

template/.eslintrc

@@ -4,6 +4,10 @@
   "rules": {
     "react-hooks/rules-of-hooks": "error",
     "simple-import-sort/sort": "error",
-    "no-multiple-empty-lines": "error"
+    "no-multiple-empty-lines": "error",
+    "comma-dangle": ["error", "always-multiline"],
+    "eol-last": ["error", "always"],
+    "semi": ["error", "never"],
+    "quotes": ["error", "double"]
   }
 }

template/.vscode/settings.json

@@ -5,19 +5,9 @@
   "eslint.options": {
     "extensions": [".html", ".ts", ".js", ".tsx"]
   },
-  "eslint.validate": [
-    "javascript",
-    "javascriptreact",
-    {
-      "language": "typescript",
-      "autoFix": true
-    },
-    {
-      "language": "typescriptreact",
-      "autoFix": true
-    }
-  ],
-  "eslint.autoFixOnSave": true,
   "eslint.packageManager": "yarn",
-  "typescript.tsdk": "node_modules/typescript/lib"
-}
+  "typescript.tsdk": "node_modules/typescript/lib",
+  "editor.codeActionsOnSave": {
+    "source.fixAll.eslint": true
+  }
+}

template/src/components/App.test.tsx

@@ -1,9 +1,9 @@
-import React from "react";
-import { render } from "@testing-library/react";
-import App from "./App";
+import React from 'react'
+import { render } from '@testing-library/react'
+import App from './App'
 
-test("renders learn react link", () => {
-  const { getByText } = render(<App />);
-  const linkElement = getByText(/learn react/i);
-  expect(linkElement).toBeInTheDocument();
-});
+test('renders learn react link', () => {
+  const { getByText } = render(<App />)
+  const linkElement = getByText(/learn react/i)
+  expect(linkElement).toBeInTheDocument()
+})

template/src/components/App.tsx

@@ -1,4 +1,4 @@
-import React from "react";
+import React from 'react'
 
 export default () => {
   return (
@@ -11,5 +11,5 @@ export default () => {
         cra-template-unicorn
       </a>
     </h1>
-  );
-};
+  )
+}

template/src/features/index.ts

@@ -1,9 +1,9 @@
-import { combineReducers } from "@reduxjs/toolkit";
-import { configureStore } from "@reduxjs/toolkit";
+import { combineReducers } from '@reduxjs/toolkit'
+import { configureStore } from '@reduxjs/toolkit'
 
-const rootReducer = combineReducers({});
+const rootReducer = combineReducers({})
 
-const store = configureStore({ reducer: rootReducer });
+const store = configureStore({ reducer: rootReducer })
 
-export type RootState = ReturnType<typeof rootReducer>;
-export default store;
+export type RootState = ReturnType<typeof rootReducer>
+export default store

template/src/index.tsx

@@ -1,11 +1,11 @@
-import React from "react";
-import ReactDOM from "react-dom";
-import { Provider } from "react-redux";
-import { Router } from "react-router-dom";
+import React from 'react'
+import ReactDOM from 'react-dom'
+import { Provider } from 'react-redux'
+import { Router } from 'react-router-dom'
 
-import App from "@/components/App";
-import store from "@/features";
-import history from "@/utils/history";
+import App from '@/components/App'
+import store from '@/features'
+import history from '@/utils/history'
 
 ReactDOM.render(
   <Provider store={store}>
@@ -14,4 +14,4 @@ ReactDOM.render(
     </Router>
   </Provider>,
   document.getElementById("root")
-);
+)

template/src/setupTests.ts

@@ -2,4 +2,4 @@
 // allows you to do things like:
 // expect(element).toHaveTextContent(/react/i)
 // learn more: https://github.com/testing-library/jest-dom
-import '@testing-library/jest-dom/extend-expect';
+import '@testing-library/jest-dom/extend-expect'

template/src/utils/history.ts

@@ -1,3 +1,3 @@
-import { createBrowserHistory } from "history";
+import { createBrowserHistory } from 'history'
 
-export default createBrowserHistory();
+export default createBrowserHistory()